-
Notifications
You must be signed in to change notification settings - Fork 127
Expand file tree
/
Copy pathCron.updateValue.test.tsx
More file actions
525 lines (442 loc) · 13.8 KB
/
Cron.updateValue.test.tsx
File metadata and controls
525 lines (442 loc) · 13.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
import { render, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { useState } from 'react'
import Cron from '../Cron'
describe('Cron update value test suite', () => {
it("should check that it's possible to change the period from minute to year", async () => {
const user = userEvent.setup()
const value = '* * * * *'
const setValue = vi.fn()
render(<Cron value={value} setValue={setValue} />)
// Open Period dropdown
await waitFor(() => {
user.click(screen.getByText('minute'))
})
// Select year period
await waitFor(() => {
user.click(screen.getByText('year'))
})
// Check dropdowns values
await waitFor(() => {
expect(screen.getByTestId('select-period').textContent).toContain('year')
expect(screen.getByTestId('custom-select-months').textContent).toContain(
'every month',
)
expect(
screen.getByTestId('custom-select-month-days').textContent,
).toContain('every day of the month')
expect(
screen.getByTestId('custom-select-week-days').textContent,
).toContain('every day of the week')
expect(screen.getByTestId('custom-select-hours').textContent).toContain(
'every hour',
)
expect(screen.getByTestId('custom-select-minutes').textContent).toContain(
'every minute',
)
})
})
it("should check that it's possible to select specific minutes", async () => {
const user = userEvent.setup()
const value = '1,4 * * * *'
const setValue = vi.fn()
render(<Cron value={value} setValue={setValue} />)
// Open minute dropdown
await waitFor(() => user.click(screen.getByText('1,4')))
// Select another minute value
await waitFor(() => user.click(screen.getByText('59')))
// Check dropdowns values
expect(await screen.findByText('1,4,59')).toBeVisible()
})
it("should check that it's possible to select a periodicity with double click", async () => {
const user = userEvent.setup()
const value = '1,4 * * * *'
const setValue = vi.fn()
render(<Cron value={value} setValue={setValue} />)
// Open minute dropdown
await waitFor(() => {
user.click(screen.getByText('1,4'))
})
// Select another minute value
await waitFor(() => {
user.dblClick(screen.getByText('2'))
})
// Check dropdowns values
await waitFor(() => {
expect(screen.getByTestId('custom-select-minutes').textContent).toContain(
'every 2',
)
})
})
it("should check that it's possible to change a periodicity with double click", async () => {
const user = userEvent.setup()
const value = '*/2 * * * *'
const setValue = vi.fn()
render(<Cron value={value} setValue={setValue} />)
// Open minute dropdown
await waitFor(() => {
user.click(screen.getByText('every 2'))
})
// Select another minute value
await waitFor(() => {
user.dblClick(screen.getByText('4'))
})
// Check dropdowns values
await waitFor(() => {
expect(screen.getByTestId('custom-select-minutes').textContent).toContain(
'every 4',
)
})
})
it("should check that it's possible to clear cron value", async () => {
const user = userEvent.setup()
const value = '1 1 1 1 1'
const setValue = vi.fn()
render(<Cron value={value} setValue={setValue} />)
// Clear cron value
await waitFor(() => {
user.click(screen.getByText('Clear'))
})
// Check dropdowns values
await waitFor(() => {
expect(setValue).toHaveBeenNthCalledWith(2, '* * * * *', {
selectedPeriod: 'year',
})
})
})
it("should check that it's possible to clear cron value with empty", async () => {
const user = userEvent.setup()
const value = '1 1 1 1 1'
const setValue = vi.fn()
render(<Cron value={value} setValue={setValue} clearButtonAction='empty' />)
// Clear cron value
await waitFor(() => {
user.click(screen.getByText('Clear'))
})
// Check dropdowns values
await waitFor(() => {
expect(setValue).toHaveBeenNthCalledWith(2, '', {
selectedPeriod: 'year',
})
})
})
it("should check that it's possible to clear cron value when @reboot is set", async () => {
const user = userEvent.setup()
const value = '@reboot'
const setValue = vi.fn()
render(<Cron value={value} setValue={setValue} shortcuts={true} />)
// Clear cron value
await waitFor(() => {
user.click(screen.getByText('Clear'))
})
// Check dropdowns values
await waitFor(() => {
expect(setValue).toHaveBeenNthCalledWith(2, '* * * * *', {
selectedPeriod: 'day',
})
})
})
it('should check that pressing clear setting an empty value throw an error if not allowed', async () => {
const user = userEvent.setup()
const value = '1 1 1 1 1'
const setValue = vi.fn()
const onError = vi.fn()
render(
<Cron
value={value}
setValue={setValue}
allowEmpty='never'
clearButtonAction='empty'
onError={onError}
/>,
)
// Clear cron value
await waitFor(() => {
user.click(screen.getByText('Clear'))
})
// Check dropdowns values and error
await waitFor(() => {
expect(setValue).toHaveBeenNthCalledWith(2, '', {
selectedPeriod: 'year',
})
expect(onError).toHaveBeenNthCalledWith(3, {
description: 'Invalid cron expression',
type: 'invalid_cron',
})
})
})
it("should check that pressing clear setting an empty value don't throw an error if not allowed", async () => {
const user = userEvent.setup()
const value = '1 1 1 1 1'
const setValue = vi.fn()
const onError = vi.fn()
render(
<Cron
value={value}
setValue={setValue}
allowEmpty='always'
clearButtonAction='empty'
onError={onError}
/>,
)
// Clear cron value
await waitFor(() => {
user.click(screen.getByText('Clear'))
})
// Check dropdowns values and error
await waitFor(() => {
expect(setValue).toHaveBeenNthCalledWith(2, '', {
selectedPeriod: 'year',
})
expect(onError).toHaveBeenNthCalledWith(3, undefined)
})
})
it("should check that it's not possible to update value when it's readOnly mode", async () => {
const user = userEvent.setup()
const value = '1,4 * * * *'
const setValue = vi.fn()
render(<Cron value={value} setValue={setValue} readOnly />)
// Open minute dropdown
await waitFor(() => user.click(screen.getByText('1,4')))
// Check dropdown is not visible
await waitFor(() => {
expect(screen.queryByText('59')).not.toBeInTheDocument()
})
// Check dropdowns values still the sane
expect(await screen.findByText('1,4')).toBeVisible()
})
it("should check that it's not possible to update value when it's disabled mode", async () => {
const user = userEvent.setup()
const value = '1,4 * * * *'
const setValue = vi.fn()
render(<Cron value={value} setValue={setValue} disabled />)
// Open minute dropdown
await waitFor(() => user.click(screen.getByText('1,4')))
// Check dropdown is not visible
await waitFor(() => {
expect(screen.queryByText('59')).not.toBeInTheDocument()
})
// Check dropdowns values still the sane
expect(await screen.findByText('1,4')).toBeVisible()
})
it('should not cause infinite re-renders when dropdownsConfig is passed as inline object (issue #67)', async () => {
const renderCount = { current: 0 }
function Wrapper() {
const [value, setValue] = useState('* * 1 * *')
renderCount.current++
return (
<Cron
value={value}
setValue={setValue}
dropdownsConfig={{
'month-days': {
mode: 'single',
},
}}
/>
)
}
render(<Wrapper />)
// Wait for the component to stabilize
await waitFor(() => {
expect(screen.getByTestId('select-period')).toBeVisible()
})
// Without the fix, renderCount would grow unboundedly.
// With the fix, it should stabilize quickly.
const countAfterMount = renderCount.current
expect(countAfterMount).toBeLessThan(20)
})
it('should check that pressing clear with fill-with-every throws an error if allowEmpty is never', async () => {
const user = userEvent.setup()
const value = '1 1 1 1 1'
const setValue = vi.fn()
const onError = vi.fn()
render(
<Cron
value={value}
setValue={setValue}
allowEmpty='never'
onError={onError}
/>,
)
// Clear cron value (default clearButtonAction is 'fill-with-every')
await waitFor(() => {
user.click(screen.getByText('Clear'))
})
// Check that error is raised because * * * * * is empty
await waitFor(() => {
expect(setValue).toHaveBeenNthCalledWith(2, '* * * * *', {
selectedPeriod: 'year',
})
expect(onError).toHaveBeenLastCalledWith({
description: 'Invalid cron expression',
type: 'invalid_cron',
})
})
})
it("should check that pressing clear with fill-with-every doesn't throw an error if allowEmpty is for-default-value", async () => {
const user = userEvent.setup()
const value = '1 1 1 1 1'
const setValue = vi.fn()
const onError = vi.fn()
render(
<Cron
value={value}
setValue={setValue}
allowEmpty='for-default-value'
onError={onError}
/>,
)
// Clear cron value (default clearButtonAction is 'fill-with-every')
await waitFor(() => {
user.click(screen.getByText('Clear'))
})
// The clear button is an explicit reset action — it should not trigger
// a 'for-default-value' error even though * * * * * is treated as empty.
// The 'for-default-value' check only applies to manual dropdown changes
// and external value updates, not to the clear button.
await waitFor(() => {
expect(setValue).toHaveBeenNthCalledWith(2, '* * * * *', {
selectedPeriod: 'year',
})
expect(onError).toHaveBeenLastCalledWith(undefined)
})
})
it("should check that pressing clear with fill-with-every doesn't throw an error if allowEmpty is always", async () => {
const user = userEvent.setup()
const value = '1 1 1 1 1'
const setValue = vi.fn()
const onError = vi.fn()
render(
<Cron
value={value}
setValue={setValue}
allowEmpty='always'
onError={onError}
/>,
)
// Clear cron value (default clearButtonAction is 'fill-with-every')
await waitFor(() => {
user.click(screen.getByText('Clear'))
})
// Check that no error is raised
await waitFor(() => {
expect(setValue).toHaveBeenNthCalledWith(2, '* * * * *', {
selectedPeriod: 'year',
})
expect(onError).toHaveBeenLastCalledWith(undefined)
})
})
it('should trigger error when external value changes to * * * * * with allowEmpty never', async () => {
const setValue = vi.fn()
const onError = vi.fn()
const { rerender } = render(
<Cron
value='0 12 * * *'
setValue={setValue}
allowEmpty='never'
onError={onError}
/>,
)
// Change value externally to all wildcards
rerender(
<Cron
value='* * * * *'
setValue={setValue}
allowEmpty='never'
onError={onError}
/>,
)
await waitFor(() => {
expect(onError).toHaveBeenLastCalledWith({
description: 'Invalid cron expression',
type: 'invalid_cron',
})
})
})
it('should trigger error when external value changes to * * * * * with allowEmpty for-default-value', async () => {
const setValue = vi.fn()
const onError = vi.fn()
const { rerender } = render(
<Cron
value='0 12 * * *'
setValue={setValue}
allowEmpty='for-default-value'
onError={onError}
/>,
)
// Change value externally to all wildcards
rerender(
<Cron
value='* * * * *'
setValue={setValue}
allowEmpty='for-default-value'
onError={onError}
/>,
)
await waitFor(() => {
expect(onError).toHaveBeenLastCalledWith({
description: 'Invalid cron expression',
type: 'invalid_cron',
})
})
})
it('should check that week-days and minutes options are filtered with dropdownConfig', async () => {
const user = userEvent.setup()
const value = '4,6 * * * 1'
const setValue = vi.fn()
render(
<Cron
value={value}
setValue={setValue}
dropdownsConfig={{
'minutes': {
// Remove minute 59 and 58
filterOption: ({ value }) => Number(value) < 58,
},
'week-days': {
// Remove sunday
filterOption: ({ value }) => Number(value) !== 0,
},
}}
/>,
)
// Open minutes dropdown
await waitFor(() => {
user.click(screen.getByText('4,6'))
})
// Check minutes
await waitFor(() => {
for (let i = 0; i < 60; i++) {
if (i < 58) {
expect(screen.getByText(i)).toBeInTheDocument()
} else {
expect(screen.queryByText(i)).not.toBeInTheDocument()
}
}
})
// Open week-days dropdown
await waitFor(() => {
user.click(screen.getByText('MON'))
})
// Check days of the week
await waitFor(() => {
const days = [
'Sunday',
'Monday',
'Tuesday',
'Wednesday',
'Thursday',
'Friday',
'Saturday',
]
for (let i = 0; i < 7; i++) {
if (i === 0) {
expect(screen.queryByText(days[i])).not.toBeInTheDocument()
} else {
expect(screen.getByText(days[i])).toBeInTheDocument()
}
}
})
})
})