allow support for falsy values like 0 in tagged literal#45
Merged
bcoe merged 2 commits intoyargs:masterfrom Aug 10, 2017
JamesKyburz:falsy-support-tagged-literal
Merged
allow support for falsy values like 0 in tagged literal#45bcoe merged 2 commits intoyargs:masterfrom JamesKyburz:falsy-support-tagged-literal
bcoe merged 2 commits intoyargs:masterfrom
JamesKyburz:falsy-support-tagged-literal
Conversation
Member
|
@JamesKyburz good catch 👍 mind adding a little regression test when you get two secs? |
Contributor
Author
|
will do! |
Contributor
Author
|
Sorry for the delay, I have now added a test for falsy arguments to the pull request :) |
Contributor
Author
|
Could this please be merged? |
Member
|
@JamesKyburz sorry for the slow reply 👍 have been trying to dig myself out of an OSS backlog. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the
undefinedcheck the lookup key with %s won't be found when passing falsy values.