lint fixes; upd SharedModules

Author: yuliskov

MediaServiceCore

@@ -34,6 +34,12 @@ android {
         }
     }
 
+    lintOptions {
+        abortOnError true
+        disable 'MissingTranslation'
+        disable 'MissingQuantity'
+    }
+
     // gradle 4.6 migration: disable dimensions mechanism
     // more: https://proandroiddev.com/advanced-android-flavors-part-4-a-new-version-fc2ad80c01bb
     flavorDimensions "default"

SharedModules

@@ -36,16 +36,21 @@
 import android.telephony.TelephonyManager;
 import android.text.Spannable;
 import android.text.SpannableString;
+import android.text.SpannableStringBuilder;
 import android.text.Spanned;
 import android.text.style.AbsoluteSizeSpan;
+import android.text.style.ClickableSpan;
 import android.text.style.ForegroundColorSpan;
 import android.text.style.ImageSpan;
 import android.text.style.StyleSpan;
+import android.text.style.URLSpan;
 import android.view.KeyEvent;
+import android.view.View;
 import android.view.Window;
 import android.view.WindowManager;
 import android.view.inputmethod.BaseInputConnection;
 
+import androidx.annotation.NonNull;
 import androidx.browser.customtabs.CustomTabsIntent;
 import androidx.core.app.NotificationCompat;
 import androidx.core.content.ContextCompat;
@@ -1239,6 +1244,30 @@ public static boolean isSystemGestureArrowEnabled(Context context) {
         return false;
     }
 
+    /**
+     * Make link open in browser. Not working.
+     */
+    public static CharSequence toBrowserLink(Context context, CharSequence message) {
+        SpannableStringBuilder builder = SpannableStringBuilder.valueOf(message);
+        URLSpan[] spans = builder.getSpans(0, builder.length(), URLSpan.class);
+
+        for (URLSpan span : spans) {
+            builder.setSpan(new ClickableSpan() {
+                                @Override
+                                public void onClick(@NonNull View widget) {
+                                    MessageHelpers.showMessage(context, "On link clicked " + span.getURL());
+                                }
+                            },
+                    builder.getSpanStart(span),
+                    builder.getSpanEnd(span),
+                    Spanned.SPAN_INCLUSIVE_EXCLUSIVE
+            );
+            builder.removeSpan(span);
+        }
+
+        return builder;
+    }
+
     private static void persistData(Context context) {
         VideoStateService.instance(context).persistNow();
         PlayerData.instance(context).persistNow();

common/build.gradle

@@ -714,7 +714,7 @@
     <string name="action_debug_info">Debuq məlumatı</string>
     <string name="dialog_block_channel">Kanalə bloklayın</string>
     <string name="dialog_unblock_channel">Kanalı blokdan çıxarın</string>
-    <string name="confirm_block_channel">Bütün məzmun %-dən gizlədilsin?</string>
+    <string name="confirm_block_channel">Bütün məzmun %s-dən gizlədilsin?</string>
     <string name="channel_blocked">Kanal bloklanıb</string>
     <string name="channel_unblocked">Kanal blokdan çıxarıldı</string>
     <string name="header_blocked_channels">Bloklanmış Kanallar</string>

common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/Utils.java

@@ -27,7 +27,6 @@
   <string name="category_background_playback">Afspil i baggrunden</string>
   <string name="not_implemented">Ikke implementeret</string>
   <string name="option_background_playback_off">Deaktiveret</string>
-  <string name="option_background_playback_all">Video og lyd</string>
   <string name="option_background_playback_only_audio">Kun lyd</string>
   <string name="playback_settings">Indstillinger for afspilningskvalitet</string>
   <string name="video_speed">Videohastighed</string>

common/src/main/res/values-az/strings.xml

@@ -25,6 +25,11 @@ android {
         }
     }
 
+    lintOptions {
+        abortOnError true
+        disable 'MissingTranslation'
+    }
+
     // gradle 4.6 migration: disable dimensions mechanism
     // more: https://proandroiddev.com/advanced-android-flavors-part-4-a-new-version-fc2ad80c01bb
     flavorDimensions "default"

common/src/main/res/values-da/strings.xml

@@ -119,27 +119,6 @@ android {
         }
     }
 
-    // gradle 4.6 migration: disable dimensions mechanism
-    // more: https://proandroiddev.com/advanced-android-flavors-part-4-a-new-version-fc2ad80c01bb
-    flavorDimensions "default"
-
-    // NOTE: The main goal of prefixing a flavor is to group flavors' folders together
-    productFlavors {
-        stbeta {
-            applicationId "org.smarttube.beta"
-            targetSdkVersion project.properties.compileSdkVersion
-        }
-        ststable {
-            applicationId "org.smarttube.stable"
-            targetSdkVersion project.properties.compileSdkVersion
-        }
-        stfdroid {
-            applicationId "app.smarttube.fdroid"
-            minSdkVersion 21
-            targetSdkVersion project.properties.compileSdkVersion
-        }
-    }
-
     // naming example: SmartYouTubeTV_Xwalk_v6.8.12_r.apk
     // https://stackoverflow.com/questions/18332474/how-to-set-versionname-in-apk-filename-using-gradle
     applicationVariants.all { variant ->
@@ -170,7 +149,29 @@ android {
     }
 
     lintOptions {
-        checkReleaseBuilds false // fix for ClassNotFoundException: com.android.tools.lint.client.api.Vendor
+        abortOnError true
+        //checkReleaseBuilds false // fix for ClassNotFoundException: com.android.tools.lint.client.api.Vendor
+    }
+
+    // gradle 4.6 migration: disable dimensions mechanism
+    // more: https://proandroiddev.com/advanced-android-flavors-part-4-a-new-version-fc2ad80c01bb
+    flavorDimensions "default"
+
+    // NOTE: The main goal of prefixing a flavor is to group flavors' folders together
+    productFlavors {
+        stbeta {
+            applicationId "org.smarttube.beta"
+            targetSdkVersion project.properties.compileSdkVersion
+        }
+        ststable {
+            applicationId "org.smarttube.stable"
+            targetSdkVersion project.properties.compileSdkVersion
+        }
+        stfdroid {
+            applicationId "app.smarttube.fdroid"
+            minSdkVersion 21
+            targetSdkVersion project.properties.compileSdkVersion
+        }
     }
 }
 

leanbackassistant/build.gradle

@@ -18,6 +18,7 @@
     <uses-permission android:name="${applicationId}.ACCESS_VIDEO_DATA" />
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.RECORD_AUDIO" />
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
 
     <uses-sdk tools:overrideLibrary="
         androidx.leanback.preference,

smarttubetv/build.gradle

@@ -23,6 +23,7 @@
 import android.graphics.Rect;
 import android.graphics.RectF;
 import android.graphics.drawable.Drawable;
+import android.os.Build.VERSION;
 import android.os.Bundle;
 import android.util.AttributeSet;
 import android.view.MotionEvent;
@@ -398,6 +399,10 @@ private void startDrag(MotionEvent event) {
     }
 
     private void setHotspot(float x, float y) {
+        if (VERSION.SDK_INT < 21) {
+            return;
+        }
+
         final Drawable bg = getBackground();
         if (bg != null) {
             bg.setHotspot(x, y);