AppDialog: Android 8 opaque fallback

Author: yuliskov

smarttubetv/src/main/AndroidManifest.xml

@@ -142,6 +142,15 @@
                   android:screenOrientation="unspecified"
                   android:theme="@style/App.Theme.Leanback.Preferences"/>
 
+        <!-- Android 8 fallback -->
+        <activity android:name="com.liskovsoft.smartyoutubetv2.tv.ui.dialogs.AppDialogActivityOpaque"
+            android:noHistory="true"
+            android:excludeFromRecents="true"
+            android:launchMode="singleInstance"
+            android:configChanges="screenSize|smallestScreenSize|screenLayout|orientation|layoutDirection"
+            android:screenOrientation="unspecified"
+            android:theme="@style/App.Theme.Leanback.Preferences.Opaque"/>
+
         <activity
             android:name="com.liskovsoft.smartyoutubetv2.tv.ui.browse.BrowseActivity"
             android:launchMode="singleInstance"

smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/AppDialogActivityOpaque.java

@@ -0,0 +1,5 @@
+package com.liskovsoft.smartyoutubetv2.tv.ui.dialogs;
+
+// Android 8 fallback
+public class AppDialogActivityOpaque extends AppDialogActivity {
+}

smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/main/MainApplication.java

@@ -1,5 +1,7 @@
 package com.liskovsoft.smartyoutubetv2.tv.ui.main;
 
+import android.os.Build.VERSION;
+
 import androidx.multidex.MultiDexApplication;
 
 import com.liskovsoft.sharedutils.helpers.Helpers;
@@ -25,6 +27,7 @@
 import com.liskovsoft.smartyoutubetv2.tv.ui.channel.ChannelActivity;
 import com.liskovsoft.smartyoutubetv2.tv.ui.channeluploads.ChannelUploadsActivity;
 import com.liskovsoft.smartyoutubetv2.tv.ui.dialogs.AppDialogActivity;
+import com.liskovsoft.smartyoutubetv2.tv.ui.dialogs.AppDialogActivityOpaque;
 import com.liskovsoft.smartyoutubetv2.tv.ui.playback.PlaybackActivity;
 import com.liskovsoft.smartyoutubetv2.tv.ui.search.tags.SearchTagsActivity;
 import com.liskovsoft.smartyoutubetv2.tv.ui.signin.SignInActivity;
@@ -74,11 +77,21 @@ public void onCreate() {
     private void setupViewManager() {
         ViewManager viewManager = ViewManager.instance(this);
 
+        Class<? extends AppDialogActivity> dialogClazz;
+
+        if (VERSION.SDK_INT == 26
+                && Helpers.equalsAny(Helpers.getCrashlyticsDeviceName(), "4S806_Z51S1 (Panasonic)")) {
+            // The fix: Only fullscreen opaque activities can request orientation
+            dialogClazz = AppDialogActivityOpaque.class;
+        } else {
+            dialogClazz = AppDialogActivity.class;
+        }
+
         viewManager.setRoot(BrowseActivity.class);
         viewManager.register(SplashView.class, SplashActivity.class); // no parent, because it's root activity
         viewManager.register(BrowseView.class, BrowseActivity.class); // no parent, because it's root activity
         viewManager.register(PlaybackView.class, PlaybackActivity.class, BrowseActivity.class);
-        viewManager.register(AppDialogView.class, AppDialogActivity.class, BrowseActivity.class);
+        viewManager.register(AppDialogView.class, dialogClazz, BrowseActivity.class);
         viewManager.register(SearchView.class, SearchTagsActivity.class, BrowseActivity.class);
         viewManager.register(SignInView.class, SignInActivity.class, BrowseActivity.class);
         viewManager.register(AddDeviceView.class, AddDeviceActivity.class, BrowseActivity.class);

smarttubetv/src/main/res/values-v26/styles.xml

@@ -97,6 +97,11 @@
     </style>
     <!-- Give ability to override style for different api -->
     <style name="App.Theme.Leanback.Preferences" parent="App.Theme.Leanback.Preferences.Base" />
+    <!-- Android 8 fallback -->
+    <style name="App.Theme.Leanback.Preferences.Opaque" parent="App.Theme.Leanback.Preferences.Base">
+        <!-- IllegalStateException: Only fullscreen opaque activities can request orientation -->
+        <item name="android:windowIsTranslucent">false</item>
+    </style>
     <!-- End Color scheme: Teal (Default) -->
 
     <!--  Color scheme: Dark Grey  -->