Skip to content

Commit eaf479f

Browse files
committed
Mem leak fixes: AppDialogActivity, PlaybackActivity
1 parent 2919871 commit eaf479f

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/CommentsController.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ public void onCommentLongClicked(CommentItem commentItem) {
112112

113113
@Override
114114
public void onFinish(Backup backup) {
115+
super.onFinish(backup);
115116
if (Helpers.equals(backupKey, mCommentsKey)) {
116117
mBackup = new Pair<>(mCommentsKey, backup);
117118
}

common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/ui/AbstractCommentsReceiver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public abstract class AbstractCommentsReceiver implements CommentsReceiver {
1010
private Callback mCallback;
1111

1212
public AbstractCommentsReceiver(Context context) {
13-
mContext = context;
13+
mContext = context.getApplicationContext(); // Mem leak fix (holds PlaybackActivity)
1414
}
1515

1616
@Override
@@ -56,7 +56,7 @@ public void onCommentLongClicked(CommentItem commentItem) {
5656

5757
@Override
5858
public void onFinish(Backup backup) {
59-
59+
setCallback(null); // Mem leak fix (holds AppDialogActivity)
6060
}
6161

6262
@Override

common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/AppDialogPresenter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ private void clear() {
6868
mTimeoutMs = 0;
6969
mHandler.removeCallbacks(mCloseDialog);
7070
resetData();
71+
mBackupCategories = null; // Mem leak fix (UiOption callback holds PlaybackActivity)
7172
}
7273

7374
/**

0 commit comments

Comments
 (0)