french translation

[rainje]

No description provided.

[FezVrasta]

Could you use ’ instead of '? ' is not an apostrophe.

[rainje]

Well it is actually, at least in french.

If it's an issue with the extension i'll change it, you tell me.

[FezVrasta]

Ok but the right one is the typographic one, it's used in every translation around the web. Thanks.

[zaggino]

If the translation author wants to use that one, I don't see a problem? I googled that and they use single quote for apostrphes: http://french.about.com/library/writing/bl-symbols.htm

[rainje]

They are all correct and no it's not in every translation, it's not even on the french keyboard !

If the single quote isnt an issue with the extension, then my translation's fine ;)

[zaggino]

One thing though - you need to modify also file nls/strings.js and add "fr":true there.

[zaggino]

I'm not sure if Brackets has an autodetect for the languages now if it's working for you without it. I'll investigate later but for now add it there and I'll merge. Also you could add an entry to the changelog to version 0.13.0

[rainje]

It should be good now I guess. I also tested it on brackets and it worked fine! I had nothing to do.

[zaggino]

One last thing - I don't like repairing stuff after PR even when it's a minor thing.

[rainje]

Sorry about that, I didnt use Brackets for this. It should be fine now.

Oh god what did I do this time.

[zaggino]

we use 4 ... don't change it for us ;-)

[rainje]

Sorry, my bad.

[zaggino]

now you put tabs back, but spaceUnits are still 2 instead of 4 :)

[zaggino]

Hint: Always check the latest diff here https://github.com/zaggino/brackets-git/pull/310/files

[rainje]

Good idea, thanks. Sorry about that.

[zaggino]

Hope you don't mind if I squash your 8 commits into one before merging ;-)

[rainje]

I have no idea how you'll do this but i'm ok with it.

[zaggino]

Here it's 3fc8fa6

Thanks for the translation 👍

[rainje]

Thanks for this nice extension!