fix: prevent rejecting verified transactions (#224)

fix: prevent rejecting verified transactions

Author: kodiakhq[bot]

app/models/enum.ts

@@ -27,9 +27,10 @@ export const TRANSACTION_STATUS = {
   SUBMITTED: 'SUBMITTED',
   VERIFIED: 'VERIFIED',
   REJECTED: 'REJECTED',
-}
+} as const
 
-export type TransactionStatus = 'SUBMITTED' | 'VERIFIED' | 'REJECTED'
+export type TransactionStatus =
+  typeof TRANSACTION_STATUS[keyof typeof TRANSACTION_STATUS]
 
 export const TRANSACTION_METHOD = {
   BANK_TRANSFER: 'BANK_TRANSFER',

app/routes/dashboard.transactions.$transactionId.$action.tsx

@@ -15,6 +15,7 @@ import {
   TransactionWithUser,
   updateTransactionStatus,
 } from '~/models/transaction'
+import { canUpdateTransactionStatus } from '~/utils/transaction-status'
 import { printLocaleDateTimeString, printRupiah } from '~/utils/format'
 import { TransactionStatus, TRANSACTION_STATUS } from '~/models/enum'
 import { requireUser } from '~/services/auth.server'
@@ -75,6 +76,26 @@ export const action: ActionFunction = async ({ request, params }) => {
     }
   }
 
+  const existingTransaction = await getTransactionById(transactionId)
+  if (!existingTransaction) {
+    return redirect('/dashboard/transactions')
+  }
+
+  if (
+    !canUpdateTransactionStatus(
+      existingTransaction.status as TransactionStatus,
+      status as TransactionStatus
+    )
+  ) {
+    throw json(
+      {
+        formError:
+          'Transaksi yang sudah diverifikasi tidak dapat diubah menjadi ditolak.',
+      },
+      { status: 400 }
+    )
+  }
+
   const transaction = await updateTransactionStatus(
     transactionId,
     notes,

app/routes/dashboard.transactions.$transactionId.tsx

@@ -49,11 +49,13 @@ export default function TransactionDetailsPage() {
     <SingleColumnLayout>
       <div className="min-h-full">
         <TransactionDetails transaction={transaction} user={transaction.user}>
-          {/* TODO: Disable rejecting a verified transaction */}
           <TertiaryButtonLink
             to={`reject?${searchParams.toString()}`}
             replace
-            disabled={transaction.status === TRANSACTION_STATUS.REJECTED}
+            disabled={
+              transaction.status === TRANSACTION_STATUS.REJECTED ||
+              transaction.status === TRANSACTION_STATUS.VERIFIED
+            }
           >
             Tolak Transaksi
           </TertiaryButtonLink>

app/utils/__tests__/transaction-status.test.ts

@@ -0,0 +1,58 @@
+import { canUpdateTransactionStatus } from '../transaction-status'
+import { TRANSACTION_STATUS } from '~/models/enum'
+
+describe('canUpdateTransactionStatus', () => {
+  it('allows submitted to verified', () => {
+    expect(
+      canUpdateTransactionStatus(
+        TRANSACTION_STATUS.SUBMITTED,
+        TRANSACTION_STATUS.VERIFIED
+      )
+    ).toBe(true)
+  })
+
+  it('allows submitted to rejected', () => {
+    expect(
+      canUpdateTransactionStatus(
+        TRANSACTION_STATUS.SUBMITTED,
+        TRANSACTION_STATUS.REJECTED
+      )
+    ).toBe(true)
+  })
+
+  it('prevents verified from being rejected', () => {
+    expect(
+      canUpdateTransactionStatus(
+        TRANSACTION_STATUS.VERIFIED,
+        TRANSACTION_STATUS.REJECTED
+      )
+    ).toBe(false)
+  })
+
+  it('allows verified to remain verified', () => {
+    expect(
+      canUpdateTransactionStatus(
+        TRANSACTION_STATUS.VERIFIED,
+        TRANSACTION_STATUS.VERIFIED
+      )
+    ).toBe(true)
+  })
+
+  it('allows rejected to be re-verified', () => {
+    expect(
+      canUpdateTransactionStatus(
+        TRANSACTION_STATUS.REJECTED,
+        TRANSACTION_STATUS.VERIFIED
+      )
+    ).toBe(true)
+  })
+
+  it('allows rejected to remain rejected', () => {
+    expect(
+      canUpdateTransactionStatus(
+        TRANSACTION_STATUS.REJECTED,
+        TRANSACTION_STATUS.REJECTED
+      )
+    ).toBe(true)
+  })
+})

app/utils/transaction-status.ts

@@ -0,0 +1,15 @@
+import { TransactionStatus, TRANSACTION_STATUS } from '~/models/enum'
+
+export function canUpdateTransactionStatus(
+  currentStatus: TransactionStatus,
+  destinationStatus: TransactionStatus
+) {
+  if (
+    currentStatus === TRANSACTION_STATUS.VERIFIED &&
+    destinationStatus === TRANSACTION_STATUS.REJECTED
+  ) {
+    return false
+  }
+
+  return true
+}

test/test-utils.tsx

@@ -22,7 +22,14 @@ export function createRemixStubWrapper(
       Component: () => ui,
     },
   ])
-  return <RemixStub initialEntries={initialEntries} />
+  return (
+    <RemixStub
+      initialEntries={initialEntries}
+      future={{
+        v3_relativeSplatPath: true,
+      }}
+    />
+  )
 }
 
 /**