fix(core): Set prototype & name for custom errors

Author: zenflow

src/core/InternalError.ts

@@ -4,6 +4,7 @@ const genericMessage =
 export class InternalError extends Error {
   constructor(message: string) {
     super(`${message}. ${genericMessage}`)
-    // Object.setPrototypeOf(this, InternalError.prototype)
+    Object.setPrototypeOf(this, InternalError.prototype)
   }
 }
+InternalError.prototype.name = InternalError.name

src/core/validateAndNormalizeConfig.ts

@@ -130,8 +130,12 @@ function validateDependencyTree(services: {
 }
 
 export class ConfigValidationError extends Error {
-  name = 'ConfigValidationError'
+  constructor(message: string) {
+    super(message)
+    Object.setPrototypeOf(this, ConfigValidationError.prototype)
+  }
 }
+ConfigValidationError.prototype.name = ConfigValidationError.name
 
 function validateType(checker: Checker, reportedPath: string, value: any) {
   checker.setReportedPath(reportedPath)

test/integration/crashing.test.ts

@@ -67,13 +67,15 @@ describe('crashing', () => {
     `
     proc = new CompositeProcess(script)
     await proc.ended
-    expect(redactStackTraces(proc.flushOutput().slice(4)))
-      .toMatchInlineSnapshot(`
+    const output = redactStackTraces(proc.flushOutput())
+    output.shift() // ignore first line like "<file path>:<line number>"
+    expect(output).toMatchInlineSnapshot(`
       Array [
+        "    throw new ConfigValidationError('\`config.services\` has no entries');",
+        "    ^",
+        "",
         "ConfigValidationError: \`config.services\` has no entries",
         "<stack trace>",
-        "  name: 'ConfigValidationError'",
-        "}",
         "",
         "",
       ]

test/integration/helpers/composite-process.ts

@@ -71,6 +71,7 @@ export class CompositeProcessCrashError extends Error {
         '--------------\n',
       ].join('\n'),
     )
-    // Object.setPrototypeOf(this, CompositeProcessCrashError.prototype)
+    Object.setPrototypeOf(this, CompositeProcessCrashError.prototype)
   }
 }
+CompositeProcessCrashError.prototype.name = CompositeProcessCrashError.name

test/integration/helpers/redact.ts

@@ -1,8 +1,6 @@
 /* This file contains helpers to redact bits of text from console `lines`
     so that we have something consistent that we can snapshot. */
 
-import path from 'path'
-
 export function redactStackTraces(lines: string[]) {
   const output = [...lines]
   let stackTrace: StackTrace | false = false
@@ -30,13 +28,12 @@ function findStackTrace(lines: string[]): StackTrace | false {
   return { start, length }
 }
 
-export function redactEscapedCwdInstances(lines: string[]) {
-  const cwd = path.join(process.cwd(), path.sep)
-  const escapedCwd = JSON.stringify(cwd).slice(1, -1)
+export function redactCwd(lines: string[]) {
+  const cwd = process.cwd()
   return lines.map(line => {
     let result = line
-    while (result.includes(escapedCwd)) {
-      result = result.replace(escapedCwd, '<cwd>')
+    while (result.includes(cwd)) {
+      result = result.replace(cwd, '<cwd>')
     }
     return result
   })