Skip to content

Commit 39cdb9c

Browse files
committed
Keep SparkFunSuite-dependent methods in SQLTestUtils
Methods like withTempDir, testQuietly, testWithWholeStageCodegenOnAndOff need SparkFunSuite and are used by suites that extend SQLTestUtils (via SharedSparkSession) without extending QueryTest. Keep them in SQLTestUtils; QueryTest class remains minimal. Co-authored-by: Isaac
1 parent 4a9a76d commit 39cdb9c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,12 @@ private[sql] trait SQLTestUtilsBase extends QueryTestBase { self: Suite => }
4343
/**
4444
* Helper trait that should be extended by all SQL test suites within the Spark
4545
* code base.
46+
*
47+
* This extends [[SparkFunSuite]] with [[QueryTestBase]] and adds test helpers that
48+
* depend on [[SparkFunSuite]] (e.g. `test()` overrides, `withTempDir`).
4649
*/
4750
private[sql] trait SQLTestUtils extends SparkFunSuite with SQLTestUtilsBase with PlanTest {
51+
4852
/**
4953
* Creates a temporary directory, which is then passed to `f` and will be deleted after `f`
5054
* returns.

0 commit comments

Comments
 (0)