Skip to content

Commit cc06a26

Browse files
committed
Revert changes to SharedSparkSession and TestHiveSingleton
Co-authored-by: Isaac
1 parent 59afd19 commit cc06a26

File tree

2 files changed

+1
-28
lines changed

2 files changed

+1
-28
lines changed

sql/core/src/test/scala/org/apache/spark/sql/test/SharedSparkSession.scala

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import org.apache.spark.internal.config.UNSAFE_EXCEPTION_ON_MEMORY_LEAK
2727
import org.apache.spark.sql.{classic, SparkSession, SparkSessionProvider, SQLContext}
2828
import org.apache.spark.sql.catalyst.expressions.CodegenObjectFactoryMode
2929
import org.apache.spark.sql.catalyst.optimizer.ConvertToLocalRelation
30-
import org.apache.spark.sql.classic.{ClassicConversions, ColumnConversions, ColumnNodeToExpressionConverter, SQLImplicits}
3130
import org.apache.spark.sql.internal.{SQLConf, StaticSQLConf}
3231

3332
trait SharedSparkSession extends SQLTestUtils with SharedSparkSessionBase {
@@ -88,23 +87,6 @@ trait SharedSparkSessionBase
8887
with BeforeAndAfterEach
8988
with Eventually { self: Suite =>
9089

91-
/**
92-
* A helper object for importing SQL implicits.
93-
*
94-
* Note that the alternative of importing `spark.implicits._` is not possible here.
95-
* This is because we create the `SparkSession` immediately before the first test is run,
96-
* but the implicits import is needed in the constructor.
97-
*/
98-
protected object testImplicits
99-
extends SQLImplicits
100-
with ClassicConversions
101-
with ColumnConversions {
102-
private def classicSession: classic.SparkSession =
103-
self.spark.asInstanceOf[classic.SparkSession]
104-
override protected def session: classic.SparkSession = classicSession
105-
override protected def converter: ColumnNodeToExpressionConverter = classicSession.converter
106-
}
107-
10890
protected def sparkConf = {
10991
val conf = new SparkConf()
11092
.set("spark.hadoop.fs.file.impl", classOf[DebugFilesystem].getName)

sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHiveSingleton.scala

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,23 +19,14 @@ package org.apache.spark.sql.hive.test
1919

2020
import org.apache.spark.SparkFunSuite
2121
import org.apache.spark.sql.SparkSessionProvider
22-
import org.apache.spark.sql.classic
23-
import org.apache.spark.sql.classic.{ClassicConversions, ColumnConversions, ColumnNodeToExpressionConverter, SQLImplicits, SparkSession}
22+
import org.apache.spark.sql.classic.SparkSession
2423
import org.apache.spark.sql.hive.HiveExternalCatalog
2524
import org.apache.spark.sql.hive.client.HiveClient
2625

2726

2827
trait TestHiveSingleton extends SparkFunSuite with SparkSessionProvider {
2928
override protected val enableAutoThreadAudit = false
3029
override protected val spark: SparkSession = TestHive.sparkSession
31-
32-
protected object testImplicits
33-
extends SQLImplicits
34-
with ClassicConversions
35-
with ColumnConversions {
36-
override protected def session: SparkSession = TestHiveSingleton.this.spark
37-
override protected def converter: ColumnNodeToExpressionConverter = session.converter
38-
}
3930
protected val hiveContext: TestHiveContext = TestHive
4031
protected val hiveClient: HiveClient =
4132
spark.sharedState.externalCatalog.unwrapped.asInstanceOf[HiveExternalCatalog].client

0 commit comments

Comments
 (0)