fix: address code review feedback

- Constrain pMapValues K generic to string (matches Object.entries behavior)
- Remove unused writeJsonFile/loadJsonFile imports in rename-overwrite test
- Properly handle URL cwd in safe-execa via fileURLToPath
- Normalize args to mutable array instead of type-casting in safe-execa

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: zkochan

p-map-values/src/index.ts

@@ -1,4 +1,4 @@
-export async function pMapValues<K extends string | number | symbol, V, U> (
+export async function pMapValues<K extends string, V, U> (
   mapper: (value: V, key: K, obj: Record<K, V>) => Promise<U>,
   obj: Record<K, V>
 ): Promise<Record<K, U>> {

rename-overwrite/test.js

@@ -2,8 +2,8 @@ import fs from 'node:fs'
 import path from 'node:path'
 import { test, describe } from 'node:test'
 import assert from 'node:assert'
-import { writeJsonFile, writeJsonFileSync } from 'write-json-file'
-import { loadJsonFile, loadJsonFileSync } from 'load-json-file'
+import { writeJsonFileSync } from 'write-json-file'
+import { loadJsonFileSync } from 'load-json-file'
 import { renameOverwrite, renameOverwriteSync } from 'rename-overwrite'
 import symlinkDir from 'symlink-dir'
 import { temporaryDirectory } from 'tempy'

safe-execa/src/index.ts

@@ -1,3 +1,4 @@
+import { fileURLToPath } from 'node:url'
 import which from '@zkochan/which'
 import { execa, execaSync } from 'execa'
 import type { Options, SyncOptions, ResultPromise, SyncResult } from 'execa'
@@ -7,22 +8,29 @@ export type { Options, SyncOptions, ResultPromise, SyncResult }
 
 const pathCache = new Map<string, string | undefined>()
 
+function cwdToString (cwd: string | URL | undefined): string {
+  if (cwd == null) return process.cwd()
+  if (cwd instanceof URL) return fileURLToPath(cwd)
+  return cwd
+}
+
 export function	sync (
   file: string,
   args?: readonly string[],
   options?: SyncOptions
 ): SyncResult {
+  const normalizedArgs = args ? [...args] : []
   try {
-    which.sync(file, { path: options?.cwd as string ?? process.cwd() })
+    which.sync(file, { path: cwdToString(options?.cwd) })
   } catch (err: any) {
     // If the command is not found in the current directory, there is no need to resolve the command to full location
     // as there is no danger of binary planting attack on Windows
     if (err.code === 'ENOENT') {
-      return execaSync(file, args as string[], options)
+      return execaSync(file, normalizedArgs, options)
     }
   }
   const fileAbsolutePath = getCommandAbsolutePathSync(file, options)
-  return execaSync(fileAbsolutePath, args as string[], options)
+  return execaSync(fileAbsolutePath, normalizedArgs, options)
 }
 
 function getCommandAbsolutePathSync (file: string, options?: {
@@ -47,15 +55,16 @@ export function safeExeca (
   args?: readonly string[],
   options?: Options
 ): ResultPromise {
+  const normalizedArgs = args ? [...args] : []
   try {
-    which.sync(file, { path: options?.cwd as string ?? process.cwd() })
+    which.sync(file, { path: cwdToString(options?.cwd) })
   } catch (err: any) {
     // If the command is not found in the current directory, there is no need to resolve the command to full location
     // as there is no danger of binary planting attack on Windows
     if (err.code === 'ENOENT') {
-      return execa(file, args as string[], options)
+      return execa(file, normalizedArgs, options)
     }
   }
   const fileAbsolutePath = getCommandAbsolutePathSync(file, options)
-  return execa(fileAbsolutePath, args as string[], options)
+  return execa(fileAbsolutePath, normalizedArgs, options)
 }