Skip to content

Commit 967aff4

Browse files
authored
feat: Detailed save changes response data. (#49)
* Pull in new client NPM package for message changes to report more discrete error messages when saving changes.
1 parent 997edc9 commit 967aff4

File tree

4 files changed

+14
-15
lines changed

4 files changed

+14
-15
lines changed

package-lock.json

Lines changed: 8 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"dependencies": {
1616
"@tauri-apps/api": "^2.0.0",
1717
"@tauri-apps/plugin-cli": "^2.0.0",
18-
"@zmkfirmware/zmk-studio-ts-client": "^0.0.17",
18+
"@zmkfirmware/zmk-studio-ts-client": "^0.0.18",
1919
"emittery": "^1.0.3",
2020
"immer": "^10.1.1",
2121
"lucide-react": "^0.445.0",

src/App.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,8 @@ function App() {
209209
}
210210

211211
let resp = await call_rpc(conn.conn, { keymap: { saveChanges: true } });
212-
if (!resp.keymap?.saveChanges) {
213-
console.error("Failed to save changes", resp);
212+
if (!resp.keymap?.saveChanges || resp.keymap?.saveChanges.err) {
213+
console.error("Failed to save changes", resp.keymap?.saveChanges);
214214
}
215215
}
216216

src/rpc/useConnectedDeviceData.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
import React, { SetStateAction, useContext, useEffect, useState } from "react";
22
import { ConnectionContext } from "./ConnectionContext";
33

4-
import {
5-
call_rpc,
6-
Request,
7-
RequestResponse,
8-
} from "@zmkfirmware/zmk-studio-ts-client";
4+
import { call_rpc } from "./logging";
5+
6+
import { Request, RequestResponse } from "@zmkfirmware/zmk-studio-ts-client";
97
import { LockStateContext } from "./LockStateContext";
108
import { LockState } from "@zmkfirmware/zmk-studio-ts-client/core";
119

0 commit comments

Comments
 (0)