Skip to content

Commit ffd42ee

Browse files
authored
feat: add hover effects to device menu items
* add hover effects to device menu items * add hover styling on other buttons
1 parent 153a035 commit ffd42ee

File tree

5 files changed

+19
-15
lines changed

5 files changed

+19
-15
lines changed

src/AppFooter.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ export const AppFooter = ({
1111
<div className="grid justify-center m-1">
1212
<div>
1313
<span>&copy; 2024 - The ZMK Contributors</span> -{" "}
14-
<a href="#" onClick={onShowAbout}>
14+
<a className="hover:text-accent hover:cursor-pointer" onClick={onShowAbout}>
1515
About ZMK Studio
1616
</a>{" "}
1717
-{" "}
18-
<a href="#" onClick={onShowLicenseNotice}>
18+
<a className="hover:text-accent hover:cursor-pointer" onClick={onShowLicenseNotice}>
1919
License NOTICE
2020
</a>
2121
</div>

src/AppHeader.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ export const AppHeader = ({
5858
const showSettingsRef = useModalRef(showSettingsReset);
5959
const [unsaved, setUnsaved] = useConnectedDeviceData<boolean>(
6060
{ keymap: { checkUnsavedChanges: true } },
61-
(r) => r.keymap?.checkUnsavedChanges
61+
(r) => r.keymap?.checkUnsavedChanges,
6262
);
6363

6464
useSub("rpc_notification.keymap.unsavedChangesStatusChanged", (unsaved) =>
65-
setUnsaved(unsaved)
65+
setUnsaved(unsaved),
6666
);
6767

6868
return (
@@ -100,12 +100,12 @@ export const AppHeader = ({
100100
{connectedDeviceLabel}
101101
</Button>
102102
<Popover>
103-
<Menu className="border rounded bg-bg-base">
104-
<MenuItem className="p-1" onAction={onDisconnect}>
103+
<Menu className="border rounded bg-bg-base cursor-pointer">
104+
<MenuItem className="p-1 hover:text-accent" onAction={onDisconnect}>
105105
Disconnect
106106
</MenuItem>
107107
<MenuItem
108-
className="p-1"
108+
className="p-1 hover:text-accent"
109109
onAction={() => setShowSettingsReset(true)}
110110
>
111111
Settings Reset
@@ -117,7 +117,7 @@ export const AppHeader = ({
117117
{onUndo && (
118118
<button
119119
type="button"
120-
className="flex justify-center items-center rounded border-solid border-transparent px-3 py-1.5 border enabled:hover:border-text-base disabled:text-gray-500"
120+
className="flex justify-center items-center px-3 py-1.5 enabled:hover:text-accent disabled:text-gray-500"
121121
disabled={!canUndo}
122122
onClick={onUndo}
123123
>
@@ -131,7 +131,7 @@ export const AppHeader = ({
131131
{onRedo && (
132132
<button
133133
type="button"
134-
className="flex items-center justify-center rounded border-solid border-transparent px-3 py-1.5 border enabled:hover:border-text-base disabled:text-gray-500"
134+
className="flex items-center justify-center px-3 py-1.5 enabled:hover:text-accent disabled:text-gray-500"
135135
disabled={!canRedo}
136136
onClick={onRedo}
137137
>
@@ -143,15 +143,15 @@ export const AppHeader = ({
143143
)}
144144
<button
145145
type="button"
146-
className="rounded border-solid border-transparent px-3 py-1.5 border enabled:hover:border-text-base disabled:text-gray-500"
146+
className="px-3 py-1.5 enabled:hover:text-accent disabled:text-gray-500"
147147
disabled={!unsaved}
148148
onClick={onSave}
149149
>
150150
Save
151151
</button>
152152
<button
153153
type="button"
154-
className="rounded border-solid border-transparent px-3 py-1.5 border enabled:hover:border-text-base disabled:text-gray-500"
154+
className="px-3 py-1.5 enabled:hover:text-accent disabled:text-gray-500"
155155
onClick={onDiscard}
156156
disabled={!unsaved}
157157
>

src/ConnectModal.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,11 @@ function simpleDevicePicker(
164164

165165
let connections = transports.map((t) => (
166166
<li key={t.label} className="p-1 m-1 list-none">
167-
<button type="button" onClick={async () => setSelectedTransport(t)}>
167+
<button
168+
className="hover:text-accent"
169+
type="button"
170+
onClick={async () => setSelectedTransport(t)}
171+
>
168172
{t.label}
169173
</button>
170174
</li>

src/keyboard/LayerPicker.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export const LayerPicker = ({
171171
{onRemoveClicked && (
172172
<button
173173
type="button"
174-
className="px-2"
174+
className="px-2 hover:text-accent"
175175
disabled={!canRemove}
176176
onClick={onRemoveClicked}
177177
>
@@ -182,7 +182,7 @@ export const LayerPicker = ({
182182
<button
183183
type="button"
184184
disabled={!canAdd}
185-
className="px-2"
185+
className="px-2 hover:text-accent disabled:text-gray-500 disabled:cursor-not-allowed"
186186
onClick={onAddClicked}
187187
>
188188
+

src/keyboard/PhysicalLayoutPicker.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const PhysicalLayoutPicker = ({
4646
selectedKey={layouts[selectedPhysicalLayoutIndex].name}
4747
>
4848
<Label className="after:content-[':']">Layout</Label>
49-
<Button className="ml-4 min-w-24 text-left">
49+
<Button className="ml-4 min-w-24 text-left hover:text-accent">
5050
<SelectValue<PhysicalLayoutItem>>
5151
{(v) => {
5252
return <span>{v.selectedItem?.name}</span>;

0 commit comments

Comments
 (0)