feat: Add Download Page#105
Merged
petejohanson merged 11 commits intozmkfirmware:mainfrom Jan 16, 2025
Merged
Conversation
✅ Deploy Preview for zmk-studio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pongstr
approved these changes
Dec 21, 2024
Comment on lines
+4
to
+7
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/zmk.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>ZMK Studio - Download</title> |
Contributor
There was a problem hiding this comment.
thought: not required but it'd be nice to have when sharing the app link.
Suggested change
| <meta charset="UTF-8" /> | |
| <link rel="icon" type="image/svg+xml" href="/zmk.svg" /> | |
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |
| <title>ZMK Studio - Download</title> | |
| <title>Download ZMK Studio</title> | |
| <meta name="description" content="ZMK Studio provides runtime update functionality to ZMK powered devices, allowing users to change their keymap layers without flashing new firmware to their keyboards."> | |
| <meta property="og:title" content="Download ZMK Studio"> | |
| <meta property="og:description" content="ZMK Studio provides runtime update functionality to ZMK powered devices, allowing users to change their keymap layers without flashing new firmware to their keyboards."> | |
| <meta property="og:image" content="https://zmk.studio/zmk.svg"> | |
| <meta property="og:url" content="https://zmk.studio/download"> | |
| <meta property="og:site_name" content="Download ZMK Studio"> | |
| <meta property="og:type" content="website"> | |
| <meta name="twitter:card" content="summary_large_image"> | |
| <meta name="twitter:title" content="Download ZMK Studio"> | |
| <meta name="twitter:description" content="ZMK Studio provides runtime update functionality to ZMK powered devices, allowing users to change their keymap layers without flashing new firmware to their keyboards."> | |
| <meta name="twitter:image" content="https://zmk.studio/zmk.svg"> |
Member
Author
There was a problem hiding this comment.
Fair, I think we should do it as a follow-up since index.html is lacking this as well.
petejohanson
reviewed
Jan 6, 2025
Collaborator
petejohanson
left a comment
petejohanson
left a comment
There was a problem hiding this comment.
Thanks for working on this. A couple discussion points.
src/DownloadPage.tsx
Outdated
| setShowAll(true); | ||
| } | ||
|
|
||
| fetch("https://api.github.com/repos/zmkfirmware/zmk-studio/releases/latest") |
Collaborator
There was a problem hiding this comment.
Do we need to worry about GH rate limiting folks? Any reason not to build this in during build to avoid fetching from the API constantly?
Member
Author
There was a problem hiding this comment.
I had originally done this for simplicity. I saw another popular app do the same thing, but I can't find it now. I've refactored this to run a generation script before dev/build. Seems to work well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a download page to make the GitHub releases page for the app a little easier to use. This page gets the latest GitHub release, detects the current platform, and gives the download options in a clean way. Also shows all download options if the OS can't be detected.