Skip to content

fix: app crash when reach last index of undo stack#111

Merged
petejohanson merged 1 commit intozmkfirmware:mainfrom
pongstr:fix-undo-stack
Jan 16, 2025
Merged

fix: app crash when reach last index of undo stack#111
petejohanson merged 1 commit intozmkfirmware:mainfrom
pongstr:fix-undo-stack

Conversation

@pongstr
Copy link
Copy Markdown
Contributor

@pongstr pongstr commented Dec 13, 2024

before after
Screen.Recording.2024-12-13.at.09.57.02.mov
Screen.Recording.2024-12-13.at.09.59.04.mov

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 13, 2024

Deploy Preview for zmk-studio ready!

Name Link
🔨 Latest commit 5dc3d28
🔍 Latest deploy log https://app.netlify.com/sites/zmk-studio/deploys/677c387b9db53900080ebcbf
😎 Deploy Preview https://deploy-preview-111.preview.zmk.studio
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pongstr pongstr marked this pull request as ready for review December 13, 2024 08:00
@pongstr pongstr requested a review from Nicell December 15, 2024 09:20
Copy link
Copy Markdown
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

@petejohanson
Copy link
Copy Markdown
Collaborator

@pongstr Can you please fix this to only include the actual bug fix, so this can be reviewed? Thanks.

@pongstr
Copy link
Copy Markdown
Contributor Author

pongstr commented Jan 6, 2025

@petejohanson updated the PR. thanks!

Copy link
Copy Markdown
Collaborator

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit 3370faa into zmkfirmware:main Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants