feat(jcl-detection): Detect PROC and PROCBLIB as jcl for syntax highlighting#2614
Merged
Conversation
Signed-off-by: adam-wolfe <122040687+adam-wolfe@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
=======================================
Coverage 93.21% 93.21%
=======================================
Files 104 104
Lines 10412 10412
Branches 2200 2200
=======================================
Hits 9706 9706
Misses 705 705
Partials 1 1 ☔ View full report in Codecov by Sentry. |
16 tasks
zFernand0
approved these changes
Dec 11, 2023
zFernand0
left a comment
zFernand0
left a comment
Member
There was a problem hiding this comment.
LGTM! 😋
Thanks Vit and Adam! 🥳
traeok
approved these changes
Dec 11, 2023
traeok
left a comment
traeok
left a comment
Member
There was a problem hiding this comment.
LGTM - thanks @VitGottwald, @adam-wolfe!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Contribution originally made by @VitGottwald (#2612). Reopening a PR on a different branch to resolve some DCO and prettier issues.
This PR adds "PROC" and "PROCLIB" to the list of data set qualifiers used to identify data sets/members containing JCL (which is used for enabling syntax highlighting)
Release Notes
PROC and PROCLIB datasets are recognized as JCL files for syntax highlighting
Milestone:
2.14.0
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments