feat(prompt-creds): Expose promptCredentials for extenders to use#1699
Merged
zFernand0 merged 13 commits intoMar 31, 2022
Merged
Conversation
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
….com/zowe/vscode-extension-for-zowe into secure-values-with-imp+expose-prompt-creds Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
promptCredentials for extenders to usepromptCredentials for extenders to use
This was referenced Mar 31, 2022
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
JeffinSiby
approved these changes
Mar 31, 2022
JeffinSiby
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 As an extender, I was able to enter credentials into the input boxes and the secure credentials array was added to the correct profile with the newly input values without any errors.
….com/zowe/vscode-extension-for-zowe into secure-values-with-imp+expose-prompt-creds Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Updates:
This PR attempts to:
promptCredentialsProfilesCache#this.getLoadedProfConfigin favor of its static versionProfilesCache.getLoadedProfConfig.ProfilesCache#this.getProfileLoadedin favor of its static versionProfilesCache.getProfileLoaded.ProfilesCache#this.getProfileFromConfigin favor of its static versionProfilesCache.getProfileFromConfig.shared/ui-views#UIViews.inputBoxin favor ofZoweVsCodeExtension.inputBox(added in this PR)Notes
vscode.InputBoxOptionsare completely optional.promptCredentialswill not refresh any views after updating the v1 or v2 profiles.Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedAdditional Context
This PR depends on: