Skip to content

fix: Login and Logout with APIML Dynamic Token support#2692

Merged
traeok merged 3 commits into
mainfrom
fix-token-support
Feb 8, 2024
Merged

fix: Login and Logout with APIML Dynamic Token support#2692
traeok merged 3 commits into
mainfrom
fix-token-support

Conversation

@zFernand0

@zFernand0 zFernand0 commented Jan 29, 2024

Copy link
Copy Markdown
Member

Proposed changes

Fix the login and logout operations when the APIML feature of Dynamic Tokens is enabled

How to test

Notes:

  1. git clone https://github.com/zFernand0/api-layer -b zfernand0/test/unique/cookie apiml-unique-cookie
  2. cd apiml-unique-cookie
  3. ./gradlew build -x test
  4. npm install
  5. npm run api-layer
  6. zowe auth login apiml --host localhost --port 10010 (for credentials use: USER:validPassword)

Release Notes

Milestone: 2.14.1 (or 2.15.0)

Changelog: Fix login and logout operations with APIML Dynamic Tokens

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

temp

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

@t1m0thyj t1m0thyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0 for fixing and providing instructions to test 😋

@adam-wolfe adam-wolfe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The testing instructions were helpful.

@traeok traeok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0 for the fix and the test steps 😋

@sonarqubecloud

sonarqubecloud Bot commented Feb 8, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@traeok traeok merged commit 04de484 into main Feb 8, 2024
@traeok traeok deleted the fix-token-support branch February 8, 2024 22:48
This was referenced Feb 9, 2024
@JillieBeanSim JillieBeanSim added this to the v2.15.0 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants