fix: Login and Logout with APIML Dynamic Token support#2692
Merged
Conversation
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
t1m0thyj
approved these changes
Feb 8, 2024
t1m0thyj
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @zFernand0 for fixing and providing instructions to test 😋
adam-wolfe
approved these changes
Feb 8, 2024
adam-wolfe
left a comment
Member
There was a problem hiding this comment.
LGTM. The testing instructions were helpful.
traeok
approved these changes
Feb 8, 2024
traeok
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @zFernand0 for the fix and the test steps 😋
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed changes
Fix the login and logout operations when the APIML feature of Dynamic Tokens is enabled
How to test
Notes:
git clone https://github.com/zFernand0/api-layer -b zfernand0/test/unique/cookie apiml-unique-cookiecd apiml-unique-cookie./gradlew build -x testnpm installnpm run api-layerzowe auth login apiml --host localhost --port 10010(for credentials use:USER:validPassword)Release Notes
Milestone: 2.14.1 (or 2.15.0)
Changelog: Fix login and logout operations with APIML Dynamic Tokens
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executed