fixes: Resolve TypeError in ProfilesCache; hide quick pick separators for old VS Code versions#2771
Merged
Merged
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
…ge.json Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
changed the title
ProfilesCache.checkMergingConfigAllProfiles; version checking for quick pick separatorsProfilesCache.checkMergingConfigAllProfiles; version checking for quick pick separators
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maintenance #2771 +/- ##
===============================================
+ Coverage 93.27% 93.30% +0.03%
===============================================
Files 102 102
Lines 10582 10575 -7
Branches 2276 2202 -74
===============================================
- Hits 9870 9867 -3
+ Misses 711 707 -4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
… in Theia Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
requested review from
JillieBeanSim,
SanthoshiBoyina,
awharn,
likhithanimma1,
rudyflores,
t1m0thyj and
zFernand0
traeok
changed the title
ProfilesCache.checkMergingConfigAllProfiles; version checking for quick pick separatorsProfilesCache; hide quick pick separators for old VS Code versions
anaxceron
previously approved these changes
Mar 11, 2024
anaxceron
left a comment
anaxceron
left a comment
Contributor
There was a problem hiding this comment.
Thanks, Trae! Left a couple comments on the changelog items.
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
t1m0thyj
reviewed
Mar 11, 2024
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
16 tasks
t1m0thyj
previously approved these changes
Mar 13, 2024
zFernand0
previously approved these changes
Mar 13, 2024
zFernand0
left a comment
zFernand0
left a comment
Member
There was a problem hiding this comment.
Changes LGTM! 😋
Thanks for addressing the separators for older versions of VSC
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
fix/profcache-api-proposal
branch
from
e783a86 to
f40a368
Compare
zFernand0
previously approved these changes
Mar 14, 2024
| this.allProfiles.push(...allProfiles); | ||
| for (const profs of this.profilesByType.values()) { | ||
| profs.forEach((profile) => { | ||
| this.checkMergingConfigSingleProfile(profile); |
Member
There was a problem hiding this comment.
Clever way to clean things up a bit! 😋
anaxceron
previously approved these changes
Mar 14, 2024
traeok
force-pushed
the
fix/profcache-api-proposal
branch
from
77e2fe3 to
f40a368
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
t1m0thyj
previously approved these changes
Mar 18, 2024
zFernand0
previously approved these changes
Mar 18, 2024
zFernand0
left a comment
zFernand0
left a comment
Member
There was a problem hiding this comment.
LGTM! 😋
Curious if we should just update the lerna.json file in this PR? 😅
16 tasks
JillieBeanSim
left a comment
JillieBeanSim
left a comment
Contributor
There was a problem hiding this comment.
Hey @traeok this looks good. Are we planning a patch release and if so should the lerna be updated? I ask because we have been doing development against main and next and publishing from maintenance for minor and patch releases.
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
zFernand0
approved these changes
Mar 19, 2024
|
t1m0thyj
approved these changes
Mar 19, 2024
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #2787
This PR also resolves 2 issues not documented on ZE repo:
ProfilesCache.checkMergingConfigAllProfileswhen trying to iterate over an array that might not be defined at the time of accesscheckMergingConfigSingleProfile, I refactored the function to use that instead and removed unnecessary error handlingQuickPickItem[]in Zowe Explorer to handle separatorsRelease Notes
Milestone: 2.15 (either .0 or .1 depending on time of release)
Changelog:
ProfilesCache.checkMergingConfigAllProfiles.Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executed