Update zowe sdks and return etag from uploadFromBuffer#2785
Merged
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2785 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 110 110
Lines 10246 10246
Branches 2079 2178 +99
=======================================
Hits 9560 9560
Misses 685 685
Partials 1 1 ☔ View full report in Codecov by Sentry. |
zFernand0
previously approved these changes
Mar 14, 2024
traeok
previously approved these changes
Mar 14, 2024
4 tasks
anaxceron
previously approved these changes
Mar 14, 2024
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
traeok
approved these changes
Mar 15, 2024
anaxceron
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Proposed changes
Fixes Zowe Explorer failing to build after updating the SDKs to the latest version.
After this PR is merged we should be able to update #2777 to make fewer API calls 😋
Release Notes
Milestone: v3
Changelog: Removed string as a return type of
uploadFromBuffer, since the z/OSMF API has been fixed to return a response object that includes an etagNote: Changelog check is failing for zowe-explorer and ftp packages, but I don't think release notes are needed for just updating the sdks.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments