Update next branch with LocalStorageKey, repo rename, and provenance#2788
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
added
the
no-changelog
t1m0thyj
requested review from
JillieBeanSim,
awharn,
rudyflores,
traeok and
zFernand0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2788 +/- ##
==========================================
+ Coverage 93.30% 93.32% +0.02%
==========================================
Files 110 109 -1
Lines 10232 10218 -14
Branches 2101 2181 +80
==========================================
- Hits 9547 9536 -11
+ Misses 684 681 -3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
zFernand0
left a comment
zFernand0
left a comment
There was a problem hiding this comment.
changes LGTM! 😋
Curious about the changelog though 😋
| if (e.affectsConfiguration(globals.LOGGER_SETTINGS)) { | ||
| await vscode.commands.executeCommand("zowe.extRefresh"); | ||
| } |
There was a problem hiding this comment.
Don't we need to refresh the extension if the logger settings change?
There was a problem hiding this comment.
Yes but the logger settings aren't stored in VS Code settings.json anymore, since we moved them to local storage. I guess I should make sure that we refresh the extension properly when logging-related settings are updated in local storage 😋
There was a problem hiding this comment.
Actually we still need this, so I'll add it back and remove zowe.logger from the LocalStorageKey enum because it's still a VS Code setting.
traeok
left a comment
traeok
left a comment
There was a problem hiding this comment.
LGTM, thanks @t1m0thyj 👍
I'm in the same boat as @zFernand0's comment regarding the changelog - will approve once addressed 😁
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
zFernand0
left a comment
zFernand0
left a comment
There was a problem hiding this comment.
LGTM! 😋
Thanks for adding the logger setting back 😋
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
JillieBeanSim
left a comment
JillieBeanSim
left a comment
There was a problem hiding this comment.
Thanks @t1m0thyj for all these updates!
4 participants
Proposed changes
removeSessionmethod was accessing VS Code settings instead of local storageRelease Notes
Milestone: v3
Changelog: N/A
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments