ports: recent bug fixes for 3.1.2 release by traeok · Pull Request #3515 · zowe/zowe-explorer-vscode

traeok · 2025-03-13T13:29:54Z

Proposed changes

Ports my recent bug fixes: #3456, #3473, #3479, #3480, #3503
Also ports #3457

Release Notes

Milestone: 3.1.2

Types of changes

Bug fix (non-breaking change which fixes an issue)
Enhancement (non-breaking change which adds or improves functionality)
Breaking change (a change that would cause existing functionality to not work as expected)
Documentation (Markdown, README updates)
Other (please specify above in "Proposed changes" section)

Checklist

General

I have read the CONTRIBUTOR GUIDANCE wiki
All PR dependencies have been merged and published (if applicable)
A GIF or screenshot is included in the PR for visual changes
The pre-publish command has been executed:
- v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
- v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

There is coverage for the code that I have added
I have added new test cases and they are passing
I have manually tested the changes

Deployment

I have added developer documentation (if applicable)
Documentation should be added to Zowe Docs
- If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
- Otherwise, please check with the rest of the squad about any needed documentation before merging.
These changes may need ported to the appropriate branches (list here):

…3456) * refactor: make constructor & properties protected Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: add ZE API changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* refactor(node/ds): improve recall/migrate readability Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update ZE changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests(node/ds): Verify migration & recall in getChildren Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor(tests): add case for recalled PDS Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: use startsWith for dsorg checks Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

…3480) * refactor: check locks in dataset FS remote lookup; update AuthHandler.waitForUnlock Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: handle auth prompts for more USS scenarios Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: use latest profile in more places in FSPs; part 2 to recent bugfix Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: debounce auth prompts during parallel requests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * feat: useModal optional property for auth prompts Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(AuthHandler): use modal prompt for FSPs Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: debounce prompts using separate prompt mutexes Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(tests): use fake timers in waitForUnlock test Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: unlock all profiles after vault changed Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix tests; update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: await AuthHandler.shouldHandleAuthError Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * wip: AuthHandler & AuthUtils patch coverage Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(AuthHandler): remove unnecessary branch Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: Data Set and USS profile lock tests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: use ZoweLogger.warn instead of debug Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: remove unused useModal param Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: add ZE API changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: fix logic & remove skip on listFiles cases Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * more test cases for profile lock checks Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: fix changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

…3481) * fix: preserve table sort order after row selection Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * use initialSort for DS search table column Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(tests): update coldefs in test cases Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: restore onSortChanged event after manual testing Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* fix(ftp): Only return 401 error if auth failed Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests(ftp): Fix positive & negative test cases Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: enable zftp locks from FTP extension Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

codecov · 2025-03-13T13:30:52Z

Codecov Report

Attention: Patch coverage is 91.32948% with 15 lines in your changes missing coverage. Please review.

Project coverage is 93.24%. Comparing base (82f8269) to head (8ca4116).
Report is 1 commits behind head on release/3.1.

Files with missing lines	Patch %	Lines
...kages/zowe-explorer/src/trees/uss/UssFSProvider.ts	93.18%	6 Missing ⚠️
...we-explorer/src/trees/dataset/DatasetFSProvider.ts	86.84%	5 Missing ⚠️
...ages/zowe-explorer-api/src/profiles/AuthHandler.ts	88.46%	3 Missing ⚠️
packages/zowe-explorer/src/utils/AuthUtils.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/3.1    #3515      +/-   ##
===============================================
- Coverage        93.25%   93.24%   -0.01%     
===============================================
  Files              120      120              
  Lines            12561    12678     +117     
  Branches          2889     2803      -86     
===============================================
+ Hits             11714    11822     +108     
- Misses             846      855       +9     
  Partials             1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-03-13T14:13:40Z

📅 Suggested merge-by date: 3/27/2025

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

JillieBeanSim

LGTM! thanks @traeok for porting all of this over for patch release ❤️

traeok added 5 commits March 13, 2025 09:17

update test files to match main

048570c

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

github-project-automation Bot moved this to New Issues in Zowe Explorer for VS Code Mar 13, 2025

github-project-automation Bot added this to Zowe Explorer for VS Code Mar 13, 2025

pull-request-size Bot added the size/XXL label Mar 13, 2025

zowe-robot moved this from New Issues to In Progress in Zowe Explorer for VS Code Mar 13, 2025

github-actions Bot assigned traeok Mar 13, 2025

traeok marked this pull request as ready for review March 13, 2025 14:13

traeok requested review from JillieBeanSim, SanthoshiBoyina1, awharn, likhithanimma1, t1m0thyj and zFernand0 March 13, 2025 14:13

zowe-robot moved this from In Progress to Review/QA in Zowe Explorer for VS Code Mar 13, 2025

remove new fields from jobs table (3.2.0 feature)

8ca4116

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

JillieBeanSim approved these changes Mar 13, 2025

View reviewed changes

JillieBeanSim mentioned this pull request Mar 13, 2025

zFTP 401 error not always returned, original error returned which ZE doesn't recognize. #3517

Open

zFernand0 approved these changes Mar 18, 2025

View reviewed changes

zFernand0 merged commit bffb17b into release/3.1 Mar 18, 2025

zFernand0 deleted the port/recent-fixes branch March 18, 2025 14:14

github-project-automation Bot moved this from Review/QA to Closed in Zowe Explorer for VS Code Mar 18, 2025

traeok mentioned this pull request Mar 20, 2025

port: line overwritten by another port; avoid using cached profiles #3531

Merged

15 tasks

JillieBeanSim mentioned this pull request Apr 16, 2025

v3.2.0 Release Plan #3286

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ports: recent bug fixes for 3.1.2 release#3515

ports: recent bug fixes for 3.1.2 release#3515
zFernand0 merged 7 commits into
release/3.1from
port/recent-fixes

traeok commented Mar 13, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Mar 13, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 13, 2025

Uh oh!

JillieBeanSim left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

traeok commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Release Notes

Types of changes

Checklist

Uh oh!

codecov Bot commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Mar 13, 2025

Uh oh!

JillieBeanSim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

traeok commented Mar 13, 2025 •

edited

Loading

codecov Bot commented Mar 13, 2025 •

edited

Loading