Skip to content

feat: Support async operations + TTY dependent programs 😋#3640

Merged
zFernand0 merged 14 commits into
mainfrom
iterm-01
Jun 3, 2025
Merged

feat: Support async operations + TTY dependent programs 😋#3640
zFernand0 merged 14 commits into
mainfrom
iterm-01

Conversation

@zFernand0

@zFernand0 zFernand0 commented May 8, 2025

Copy link
Copy Markdown
Member

Proposed changes

The goal of this PR is to add support for :async and :forget special keywords (Fix #3206), while at the same time fixing multiple Ctrl+C cancellation signals AND the forwarding of stdin, stdout, and stderr (Fix #3474)

Note: The iTerms do not support streaming of output (stdout or stderr) from scripts and programs. As of now, we just wait until all output is ready to be printed out, unless you use :async or :forget 😅

Release Notes

Milestone: 3.3.0

Changelog:

  • Added support for asynchronous operations.
  • BugFix: Allowed multiple commands to be cancelled in succession.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

iterm-uss-python3-script.mov

@codecov

codecov Bot commented May 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (8a505f7) to head (8ba75a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3640      +/-   ##
==========================================
+ Coverage   93.55%   93.56%   +0.01%     
==========================================
  Files         123      123              
  Lines       13808    13823      +15     
  Branches     3239     3245       +6     
==========================================
+ Hits        12918    12934      +16     
+ Misses        888      887       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zFernand0 zFernand0 requested a review from JWaters02 May 8, 2025 20:38
@zFernand0 zFernand0 added this to the v3.3.0 milestone May 8, 2025
zFernand0 added 2 commits May 8, 2025 17:12
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@pull-request-size pull-request-size Bot added size/L and removed size/M labels May 8, 2025
@zFernand0 zFernand0 marked this pull request as ready for review May 9, 2025 13:57
@github-actions

github-actions Bot commented May 9, 2025

Copy link
Copy Markdown

📅 Suggested merge-by date: 5/23/2025

@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe Explorer for VS Code May 9, 2025
@JWaters02

Copy link
Copy Markdown
Member

Hi @zFernand0 I was able to replicate the problem in my issue the same - still getting no response from the simple program, followed by "Operation cancelled!" if I do Ctrl + C.

zFernand0 added 2 commits May 14, 2025 14:40
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
…nto iterm-01

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@github-actions

github-actions Bot commented May 14, 2025

Copy link
Copy Markdown
zowe-explorer-vsix Download
Build Details
Name Information
PR Commit 8ba75a9
Merge Commit f40a858
Size 3.28 MB
Last Updated By zFernand0
Last Updated Jun 2, 25, 7:35:21 PM UTC
Expires At Aug 31, 25, 7:33:33 PM UTC

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 changed the title feat: Support async operations 😋 feat: Support async operations + TTY dependent programs 😋 May 14, 2025
@zFernand0 zFernand0 requested a review from anaxceron May 14, 2025 18:53

@anaxceron anaxceron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment re: the changelog

Comment thread packages/zowe-explorer/CHANGELOG.md Outdated
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 requested a review from anaxceron May 14, 2025 19:02
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
zFernand0 added 3 commits May 15, 2025 13:48
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
…nto iterm-01

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 requested a review from traeok May 20, 2025 18:33
traeok
traeok previously approved these changes May 20, 2025
@github-actions

Copy link
Copy Markdown

Reminder: This pull request has a merge-by date coming up within the next 24 hours. Please review this PR as soon as possible.

@t1m0thyj @JWaters02 @JillieBeanSim

@zFernand0

Copy link
Copy Markdown
Member Author

The unexpected behavior/output is likely related to:

Comment thread packages/zowe-explorer-api/CHANGELOG.md Outdated
Comment thread packages/zowe-explorer/CHANGELOG.md Outdated
…nto iterm-01

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Comment thread packages/zowe-explorer/CHANGELOG.md Outdated
traeok
traeok previously approved these changes Jun 2, 2025

@traeok traeok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Joshua's latest suggestion but don't have any additional requests

Co-authored-by: Joshua Waters <watersjoshua2002@gmail.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 requested review from JWaters02 and traeok June 2, 2025 19:33
@zFernand0 zFernand0 dismissed JWaters02’s stale review June 2, 2025 19:34

Suggested changes made! 😋

@zFernand0 zFernand0 merged commit 805b7e1 into main Jun 3, 2025
35 checks passed
@zFernand0 zFernand0 deleted the iterm-01 branch June 3, 2025 12:41
@github-project-automation github-project-automation Bot moved this from Review/QA to Closed in Zowe Explorer for VS Code Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

iTerm(uss): Programs that produce output breaks the terminal iTerm(special): Handle asynchronous operations

5 participants