fix: secure credentials as numbers or other types#3728
Merged
Conversation
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
|
📅 Suggested merge-by date: 7/10/2025 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3728 +/- ##
========================================
Coverage 93.60% 93.60%
========================================
Files 124 124
Lines 14028 14028
Branches 3347 3199 -148
========================================
Hits 13131 13131
Misses 895 895
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anaxceron
reviewed
Jun 26, 2025
anaxceron
reviewed
Jun 26, 2025
anaxceron
left a comment
Contributor
There was a problem hiding this comment.
Left a comment re: changelog
…nto fix/cli-2519 Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
traeok
approved these changes
Jul 1, 2025
traeok
left a comment
Member
There was a problem hiding this comment.
Changes LGTM, thanks Fernando!
JillieBeanSim
approved these changes
Jul 1, 2025
JillieBeanSim
left a comment
Contributor
There was a problem hiding this comment.
thanks for working on this @zFernand0 LGTM
JillieBeanSim
pushed a commit
that referenced
this pull request
Jul 1, 2025
* fix: secure credentials as numbers or other types Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * review: update changelog Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --------- Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
16 tasks
JillieBeanSim
added a commit
that referenced
this pull request
Jul 11, 2025
* fix(uss): Treat profile node as valid for refresh button (#3695) * fix(uss): Treat profile node as valid for refresh Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix: Extender load on refresh (#3678) * init Signed-off-by: jace-roell <jace.roell@hotmail.com> * implement USS on refresh loading Signed-off-by: jace-roell <jace.roell@hotmail.com> * add 10 second resolve on readFile(), add resolved promise to promise map to prevent adding a pending promise, use Profiles.getInstance() Signed-off-by: jace-roell <jace.roell@hotmail.com> * linting Signed-off-by: jace-roell <jace.roell@hotmail.com> * remove circular dep Signed-off-by: jace-roell <jace.roell@hotmail.com> * fix tests with _resolve mock and nullable on profiles Signed-off-by: jace-roell <jace.roell@hotmail.com> * code coverage Signed-off-by: jace-roell <jace.roell@hotmail.com> * remove test Signed-off-by: jace-roell <jace.roell@hotmail.com> * ussfs provider test Signed-off-by: jace-roell <jace.roell@hotmail.com> * add promise test handling Signed-off-by: jace-roell <jace.roell@hotmail.com> * code cov Signed-off-by: jace-roell <jace.roell@hotmail.com> * fix launch.json Signed-off-by: jace-roell <jace.roell@hotmail.com> * add code cov Signed-off-by: jace-roell <jace.roell@hotmail.com> * unused import Signed-off-by: jace-roell <jace.roell@hotmail.com> * code cov Signed-off-by: jace-roell <jace.roell@hotmail.com> * cov Signed-off-by: jace-roell <jace.roell@hotmail.com> * failing test Signed-off-by: jace-roell <jace.roell@hotmail.com> * add top level describe for mocking profiles Signed-off-by: jace-roell <jace.roell@hotmail.com> * fix test title Signed-off-by: jace-roell <jace.roell@hotmail.com> * Update packages/zowe-explorer/CHANGELOG.md Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> * test Signed-off-by: jace-roell <jace.roell@hotmail.com> * remove callbacks Signed-off-by: jace-roell <jace.roell@hotmail.com> * fix test Signed-off-by: jace-roell <jace.roell@hotmail.com> * remove import Signed-off-by: jace-roell <jace.roell@hotmail.com> * Restore common code in BaseProvider and update changelog Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Fix profile await for extenders like zftp Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Store types in extenderReadyMap and fix for data sets Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Add missing patch coverage Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * review: update changelog and tsdoc 😋 Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --------- Signed-off-by: jace-roell <jace.roell@hotmail.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Node cached profile fix (#3673) * getProfile Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * changelog entry Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * add unit test Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * more unit test added Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix duplication in changelog Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix duplication of fix in changelog Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Override getProfile on ZoweTreeNode classes Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * fix unit tests Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * address codepilot, add changelog entry, run prepublish Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Update packages/zowe-explorer-api/CHANGELOG.md Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> * cover instance of impError returned that may not include errCode with 401 Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Update packages/zowe-explorer-api/CHANGELOG.md Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> * address comments Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix change Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> --------- Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Fix: Canceling 'Save Credentials' while autoStore is true and Secure Credential disabled (#3713) * Update code for Profilescache Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> * Restore code to avoid breaking change Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> * Add Changelog Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> --------- Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix: secure credentials as numbers or other types (#3728) * fix: secure credentials as numbers or other types Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * review: update changelog Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --------- Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Fix/jobs pagination defaults (#3749) * fix: disable jobs pagination by default, increase default records to 1k Signed-off-by: Joshua Waters <watersjoshua2002@gmail.com> * Update CHANGELOG.md Signed-off-by: Joshua Waters <watersjoshua2002@gmail.com> --------- Signed-off-by: Joshua Waters <watersjoshua2002@gmail.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * chore(deps): Update dompurify to ^3.2.6 (#3753) Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * fix: lint warnings and other build related items Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * update lerna Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * update CHANGELOGS Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * update zeapi changelog misplacement Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix(tests): Use different method in integration test to access ZE settings (#3718) * fix(tests): Use different method to access ZE settings Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: verify that ZE group exists Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor(test): Use KB shortcut to get to end of list Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: jace-roell <jace.roell@hotmail.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> Signed-off-by: Joshua Waters <watersjoshua2002@gmail.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> Co-authored-by: Joshua Waters <watersjoshua2002@gmail.com>
zFernand0
added a commit
that referenced
this pull request
Jul 17, 2025
* Prepare v3.2.0 Release (#3601) * chore: remove SNAPSHOT from lerna version Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * Replace import from source to import from module (#3607) * Import ILocalStorageAccess from package, not from src Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com> * Add CHANGELOG entry. Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com> --------- Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com> * fix: allow listing root in USS, fix edge case w/ `cd ..` (#3603) * fix: allow listing root in USS, fix cdup edge case Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: update test to reflect changes Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * fix: add optional chaining to tab input check (#3614) * fix: add optional chaining to tab input check Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: add patch coverage to verify graceful handling Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: add changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: add api changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: tree pagination edge cases (max items 0, descending pattern combos) (#3609) * fix: tree pagination edge cases Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: add patch coverage, refine check for sorting patterns Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * add note about 0 to disable, update handling for pg sz change Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: refresh expanded PDS on pg sz change Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * Third-Party DCO Remediation Commit for Gene Johnston <37119146+gejohnston@users.noreply.github.com> On behalf of Gene Johnston <37119146+gejohnston@users.noreply.github.com>, I, Trae Yelovich <trae.yelovich@broadcom.com>, hereby add my Signed-off-by to this commit: 5bad87f Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * `datasets` -> `dataSets`, fix event not being disposed (#3620) * chore: datasets -> dataSets Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: add onDidReceiveMessage listener to disposables array Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * resolve tests and update l10n Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * Fix duplicate nodes when adding profiles (#3625) * init Signed-off-by: jace-roell <jace.roell@hotmail.com> * changelog Signed-off-by: jace-roell <jace.roell@hotmail.com> * add unit test for case of duplicate profile types Signed-off-by: jace-roell <jace.roell@hotmail.com> --------- Signed-off-by: jace-roell <jace.roell@hotmail.com> * refactor: Move `onProfileUpdated` to API register, preserve access through getters (#3624) * wip: move event to api register Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * wip: resolve failing tests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * wip: fixed all but one test Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: resolve remaining failing tests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: work on patch coverage Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * wip: move event listener into SharedUtils Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: patch coverage for SharedUtils.handleProfileChange Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: SharedUtils.handleProfileChange coverage for error case Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: changelogs Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(ds): return empty list to paginator when request fails (#3630) Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * Third-Party DCO Remediation Commit for Jace Roell <111985297+jace-roell@users.noreply.github.com> On behalf of Jace Roell <111985297+jace-roell@users.noreply.github.com>, I, Trae Yelovich <trae.yelovich@broadcom.com>, hereby add my Signed-off-by to this commit: e4b36f9 Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * Job Spool Pagination Bug fixes (#3616) * job spool fixes Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated unit tests Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated changelog Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated jobfsprovider unit tests Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * linting errors fix Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * fix linting Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * fix Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * records to fetch 0 fix Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * unit test Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * removed unused var Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * recordstofetch is 1 fix Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * removed console log Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * set ze settings min to 2 Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * removed unit test Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated unit tests Signed-off-by: Pujal <pujal.gandhi@broadcom.com> --------- Signed-off-by: Pujal <pujal.gandhi@broadcom.com> Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * Dragging and Dropping Datasets with members bug fix (#3626) * updated code for bug fix Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated code Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated to code Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updates Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated unit test Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * unit test Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated unit tests Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated changelog Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updates for empty PDS Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated unit tests Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * updated code coverage Signed-off-by: Pujal <pujal.gandhi@broadcom.com> * changelog Signed-off-by: Pujal <pujal.gandhi@broadcom.com> --------- Signed-off-by: Pujal <pujal.gandhi@broadcom.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * Fix: Userid desync in ZE profiles tooltip (#3615) * To modify tooltips Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To pass node in checkCurrentProfile Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To call syncSessionNode in datasetFilterPrompt function Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To handle pattern tooltip Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To address userid desync in the tooltip Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * refactor: To check for node in promptCredentials Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To fix failing test cases Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * refactor: To add a check for node tooltip Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To improve unit test coverage for getDatasets function Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * refactor: To refactor refreshElement calls Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * refactor: To refactor code in AuthUtils.ts file Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To refactor tool tip update code Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> --------- Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Billie Simmons <BillieJean.Simmons@ibm.com> * Third-Party DCO Remediation Commit for Pujal Gandhi <71276682+pujal0909@users.noreply.github.com> On behalf of Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>, I, Trae Yelovich <trae.yelovich@broadcom.com>, hereby add my Signed-off-by to this commit: fadac0e Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * Third-Party DCO Remediation Commit for SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> On behalf of SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com>, I, Trae Yelovich <trae.yelovich@broadcom.com>, hereby add my Signed-off-by to this commit: f49dc62 Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com> Signed-off-by: jace-roell <jace.roell@hotmail.com> Signed-off-by: Pujal <pujal.gandhi@broadcom.com> Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com> Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> Co-authored-by: Gene Johnston <37119146+gejohnston@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> Co-authored-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com> Co-authored-by: SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> Co-authored-by: Billie Simmons <BillieJean.Simmons@ibm.com> * Bump version to 3.2.0 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Bump version to 3.3.0-SNAPSHOT [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Port Fixes #3655 #3668 (#3671) * Fix: Switch Auth Method misbehaviour (#3655) * To remove hardcoded value for base profile name Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To logout apiml token when switched to basic auth Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To logout jwt token when switched to basic auth Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * chore: To add changelog entry Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To clear mocks after a test suite Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To fix failing test cases in handleSwitchAuthentication test suite Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To fix failing test cases for tokenAuthClearSecureArray test suite Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To fix failing test cases for ssoLogout method Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To add unit test case for handleSwitchAuthentication when logout fails Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To improve code coverage Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * chore: To update changelog file Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To refactor handleSwitchAuthentication Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To fix failing test cases Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * chore: update changelog entry Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> --------- Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> Signed-off-by: SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * run prepublish Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Update SDKs (resolves log4js issue) and resolve Dependabot alerts (#3668) * chore: update SDKs to resolve log4js issue Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: API changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update SDK entry in changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update deps to fix vulns Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: restore edits to l10n (no changes made) Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> --------- Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> Signed-off-by: SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> * Prepare 3.2.1 release (#3675) * prepare 3.2.1 release Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix: Fallback to `true` if `autoStore` missing when building hover info (#3677) * fix: fallback to true when autoStore property missing Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests(Profiles): Add case for missing autoStore property Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: address changelog feedback Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> * Bump version to 3.2.1 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Bump version to 3.3.0-SNAPSHOT [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Port 3.2.2 fixes (#3740) * fix(uss): Treat profile node as valid for refresh button (#3695) * fix(uss): Treat profile node as valid for refresh Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix: Extender load on refresh (#3678) * init Signed-off-by: jace-roell <jace.roell@hotmail.com> * implement USS on refresh loading Signed-off-by: jace-roell <jace.roell@hotmail.com> * add 10 second resolve on readFile(), add resolved promise to promise map to prevent adding a pending promise, use Profiles.getInstance() Signed-off-by: jace-roell <jace.roell@hotmail.com> * linting Signed-off-by: jace-roell <jace.roell@hotmail.com> * remove circular dep Signed-off-by: jace-roell <jace.roell@hotmail.com> * fix tests with _resolve mock and nullable on profiles Signed-off-by: jace-roell <jace.roell@hotmail.com> * code coverage Signed-off-by: jace-roell <jace.roell@hotmail.com> * remove test Signed-off-by: jace-roell <jace.roell@hotmail.com> * ussfs provider test Signed-off-by: jace-roell <jace.roell@hotmail.com> * add promise test handling Signed-off-by: jace-roell <jace.roell@hotmail.com> * code cov Signed-off-by: jace-roell <jace.roell@hotmail.com> * fix launch.json Signed-off-by: jace-roell <jace.roell@hotmail.com> * add code cov Signed-off-by: jace-roell <jace.roell@hotmail.com> * unused import Signed-off-by: jace-roell <jace.roell@hotmail.com> * code cov Signed-off-by: jace-roell <jace.roell@hotmail.com> * cov Signed-off-by: jace-roell <jace.roell@hotmail.com> * failing test Signed-off-by: jace-roell <jace.roell@hotmail.com> * add top level describe for mocking profiles Signed-off-by: jace-roell <jace.roell@hotmail.com> * fix test title Signed-off-by: jace-roell <jace.roell@hotmail.com> * Update packages/zowe-explorer/CHANGELOG.md Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> * test Signed-off-by: jace-roell <jace.roell@hotmail.com> * remove callbacks Signed-off-by: jace-roell <jace.roell@hotmail.com> * fix test Signed-off-by: jace-roell <jace.roell@hotmail.com> * remove import Signed-off-by: jace-roell <jace.roell@hotmail.com> * Restore common code in BaseProvider and update changelog Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Fix profile await for extenders like zftp Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Store types in extenderReadyMap and fix for data sets Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Add missing patch coverage Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * review: update changelog and tsdoc 😋 Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --------- Signed-off-by: jace-roell <jace.roell@hotmail.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Node cached profile fix (#3673) * getProfile Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * changelog entry Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * add unit test Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * more unit test added Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix duplication in changelog Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix duplication of fix in changelog Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Override getProfile on ZoweTreeNode classes Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * fix unit tests Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * address codepilot, add changelog entry, run prepublish Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Update packages/zowe-explorer-api/CHANGELOG.md Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> * cover instance of impError returned that may not include errCode with 401 Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Update packages/zowe-explorer-api/CHANGELOG.md Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> * address comments Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix change Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> --------- Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Fix: Canceling 'Save Credentials' while autoStore is true and Secure Credential disabled (#3713) * Update code for Profilescache Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> * Restore code to avoid breaking change Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> * Add Changelog Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> --------- Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix: secure credentials as numbers or other types (#3728) * fix: secure credentials as numbers or other types Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * review: update changelog Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --------- Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Fix/jobs pagination defaults (#3749) * fix: disable jobs pagination by default, increase default records to 1k Signed-off-by: Joshua Waters <watersjoshua2002@gmail.com> * Update CHANGELOG.md Signed-off-by: Joshua Waters <watersjoshua2002@gmail.com> --------- Signed-off-by: Joshua Waters <watersjoshua2002@gmail.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * chore(deps): Update dompurify to ^3.2.6 (#3753) Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * fix: lint warnings and other build related items Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * update lerna Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * update CHANGELOGS Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * update zeapi changelog misplacement Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix(tests): Use different method in integration test to access ZE settings (#3718) * fix(tests): Use different method to access ZE settings Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: verify that ZE group exists Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor(test): Use KB shortcut to get to end of list Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: jace-roell <jace.roell@hotmail.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> Signed-off-by: Joshua Waters <watersjoshua2002@gmail.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> Co-authored-by: Joshua Waters <watersjoshua2002@gmail.com> * Bump version to 3.2.2 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Bump version to 3.3.0-SNAPSHOT [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * address merge issue Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * run prepublish Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * DCO Remediation Commit for Billie Simmons <BillieJean.Simmons@ibm.com> I, Billie Simmons <BillieJean.Simmons@ibm.com>, hereby add my Signed-off-by to this commit: bf277fb I, Billie Simmons <BillieJean.Simmons@ibm.com>, hereby add my Signed-off-by to this commit: c325186 Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Third-Party DCO Remediation Commit for Billie Simmons <BillieJean.Simmons@ibm.com> On behalf of Billie Simmons <BillieJean.Simmons@ibm.com>, I, Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>, hereby add my Signed-off-by to this commit: bf277fb On behalf of Billie Simmons <BillieJean.Simmons@ibm.com>, I, Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>, hereby add my Signed-off-by to this commit: c325186 Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * DCO Remediation Commit for Billie Simmons <BillieJean.Simmons@ibm.com> I, Billie Simmons <BillieJean.Simmons@ibm.com>, hereby add my Signed-off-by to this commit: bf277fb I, Billie Simmons <BillieJean.Simmons@ibm.com>, hereby add my Signed-off-by to this commit: c325186 Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> * fix changelog positioning Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com> Signed-off-by: jace-roell <jace.roell@hotmail.com> Signed-off-by: Pujal <pujal.gandhi@broadcom.com> Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com> Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> Signed-off-by: zowe-robot <zowe.robot@gmail.com> Signed-off-by: SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> Signed-off-by: Joshua Waters <watersjoshua2002@gmail.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Gene Johnston <37119146+gejohnston@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Jace Roell <111985297+jace-roell@users.noreply.github.com> Co-authored-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com> Co-authored-by: SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> Co-authored-by: zowe-robot <zowe.robot@gmail.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com> Co-authored-by: Joshua Waters <watersjoshua2002@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update the CLI dependency to address a ZE usability issue when secure credentials are coerced to a non-string type. For more details, see:
zowe config securestores numeric password as numeric value zowe-cli#2519Release Notes
Milestone: 3.2.2
Changelog: Fixed an issue where secure credentials were coerced to non-string types.
How to test?
Before this PR:
After this PR:
Note: You may need to install zowe-cli 8.24.0 or older so that credentials are coerced into numbers
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublishpnpm --filter vscode-extension-for-zowe vscode:prepublishCode coverage
Deployment
Further comments