Skip to content

Fix: missing import and add missing function in utils.py#3007

Open
nandinisevak03 wants to merge 4316 commits intopre_prod_v15from
me-215
Open

Fix: missing import and add missing function in utils.py#3007
nandinisevak03 wants to merge 4316 commits intopre_prod_v15from
me-215

Conversation

@nandinisevak03
Copy link
Copy Markdown

image

Bug Description

  1. utils.py was calling a build_match_conditions function from another module, but the function wasn’t imported. This caused a runtime error:
    """NameError: name 'build_match_conditions' is not defined. Did you mean:
    'build_gb_match_conditions'?
    Possible source of error: erpnext (app)"""
    2.The entire get_link_fields_grouped_by_option function was not present in the utils.py file, leading to runtime failures when called.

Fix

  1. Added the required import statement so the build_match_conditions function becomes available in the file.
  2. Added the full implementation of get_link_fields_grouped_by_option which was getting used in build_qb_match_conditions function

Result
All function calls now resolve correctly, and related features work without errors.

shubham-DT and others added 30 commits September 5, 2025 10:13
… report execution, grouping options, conditional filtering, tax calculations, and advanced query building for detailed sales analysis.
…ion, account currency handling, GL entry processing, grouping options, and full report execution flow for accounts receivable/payable analysis.
test: test coverage for Inactive Sales Items Report functionality, validating territory-based filtering, item grouping, sales data analysis, and inactive item identification across both Sales Invoice and Sales Order data sources
…ases

test: add new test cases for Payment Request  and Payment Order
test: Test Coverage for Item Wise Purchase Report functionality, validating filter handling, grouping options, additional column integration, and conditional query building for purchase data analysis.
test: test cases for delivered items to be billed and dimention wise …
fix: link validation error for test case test_validate_inter_company_transaction_address_links
Refactor: Centralize get_or_create_fiscal_year method in utils.py
fix: LinkValidationError: Could not find Tax Withholding Category: Test Service Category
test: Item-wise Sales Register Report functionality, validating basic report execution, grouping options, conditional filtering, tax calculations, and advanced query building for detailed sales analysis.
test: Open Item Report check functionality, validating filter validation, account currency handling, GL entry processing, grouping options, and full report execution flow for accounts receivable/payable analysis.
fix: #2814 Test case fail test case id's: test_account_balance_TC_ACC_365 | test_balance_sheet_TC_ACC_370
…empty filter handling, account-based reporting, balance calculations, and proper integration with general ledger entries for accurate bank statement reconciliation
…g filter handling, purchase invoice data retrieval, column structure integrity, and proper reporting of billed but not fully received items
nirali8848 and others added 26 commits November 6, 2025 19:08
chore(release): Bumped version 15.70.0
chore(release): Bumped Version 15.72.0
fix: remove asset related fields
fix: syntax error in item tax template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.