Conversation
|
Ready to go @ACCESS-NRI/hivedocsteam and @manodeep |
|
OOPPS! |
|
Try again @atteggiani |
|
Hahahaha - I was wondering about the deleted assets! Didn't look relevant to the context :D |
manodeep
left a comment
manodeep
left a comment
There was a problem hiding this comment.
Thanks for updating the docs - I have requested some clarifications, which should make the document easier to parse for users
atteggiani
left a comment
atteggiani
left a comment
There was a problem hiding this comment.
Thank you @anton-seaice, it looks good.
I just added some comments to make the whole paragraph (also the portion not touched by this PR) more legible.
|
Is this clearer @manodeep ? |
Co-authored-by: Manodeep Sinha <manodeep.sinha@anu.edu.au>
|
Should be good to go |
atteggiani
requested review from
atteggiani
and removed request for
atteggiani
atteggiani
left a comment
atteggiani
left a comment
There was a problem hiding this comment.
Thank you for the updates.
A few comments
paigem
left a comment
paigem
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @anton-seaice!
See a couple responses I added to existing comments, but I don't see any further actions required to merge this PR.
|
@atteggiani - This is ready to go for |
4 participants
Closes #1137
This makes the CICE5 instructions simpler for changing processor count, based on the newer CMake build