Skip to content

Guidelines for PRs#263

Merged
ccarouge merged 6 commits intomainfrom
101-More-guidelines-for-contributors
Nov 21, 2025
Merged

Guidelines for PRs#263
ccarouge merged 6 commits intomainfrom
101-More-guidelines-for-contributors

Conversation

@ccarouge
Copy link
Copy Markdown
Member

A PR template to help both contributors and reviewers to do things correctly.

Fixes #101

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 10, 2025

PR Preview
⚠️ There was an error in the pr-preview deployment.
For more information check the Actions tab.
2025-11-20 16:01 AEDT

@ccarouge
Copy link
Copy Markdown
Member Author

I've put all I know in the PR template. If we need other things, please add to it.

Based on main so it will be on all configurations (eventually). Planning on cherry-picking to the existing dev-* configurations once it is agreed on.

@anton-seaice
Copy link
Copy Markdown
Collaborator

Planning on cherry-picking to the existing dev-* configurations once it is agreed on.

Templates come from main branch :) This step isn't needed

@ccarouge
Copy link
Copy Markdown
Member Author

Do we need instructions for updating the manifest files as well @blimlim ?

@ccarouge
Copy link
Copy Markdown
Member Author

Added instructions about the manifests, but please edit as needed.

Comment thread .github/pull_request_template.md
Clarified usage instructions for the pull request template.
Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md
Comment thread .github/pull_request_template.md Outdated
@ccarouge
Copy link
Copy Markdown
Member Author

@anton-seaice @blimlim @manodeep I've changed the listing for the dependencies. Anyone happy to approve?

Copy link
Copy Markdown
Collaborator

@blimlim blimlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccarouge, just one tiny change

Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md
blimlim
blimlim previously approved these changes Nov 20, 2025
Copy link
Copy Markdown
Collaborator

@blimlim blimlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccarouge, looks good to me!

Add runlog section to instructions to update the manifests.
Copy link
Copy Markdown
Collaborator

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks @ccarouge !

@ccarouge ccarouge merged commit c293c40 into main Nov 21, 2025
12 of 16 checks passed
@anton-seaice anton-seaice deleted the 101-More-guidelines-for-contributors branch March 24, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More guidelines for contributors

4 participants