Skip to content

oasis3-mct: add upstream version()#313

Merged
harshula merged 1 commit intomainfrom
add-oasis3-mct-upstream-version
Sep 1, 2025
Merged

oasis3-mct: add upstream version()#313
harshula merged 1 commit intomainfrom
add-oasis3-mct-upstream-version

Conversation

@harshula
Copy link
Copy Markdown
Collaborator

@harshula harshula commented Aug 27, 2025

  • Remove static list of Fortran module files.
  • Remove function init().
  • Simplify install().

@harshula harshula self-assigned this Aug 27, 2025
@harshula
Copy link
Copy Markdown
Collaborator Author

harshula commented Aug 27, 2025 •
edited
Loading

Testing @upstream

[root@c54cdf8658a5 spack-packages]# spack install --keep-stage oasis3-mct@upstream target=x86_64 %intel@2021.10.0
...
==> Installing oasis3-mct-upstream-wtv5nkptcbiimz25adtalt6qnxjrasso [32/32]
==> No binary for oasis3-mct-upstream-wtv5nkptcbiimz25adtalt6qnxjrasso found: installing from source
==> No patches needed for oasis3-mct
==> oasis3-mct: Executing phase: 'edit'
==> oasis3-mct: Executing phase: 'build'
==> oasis3-mct: Executing phase: 'install'
==> oasis3-mct: Successfully installed oasis3-mct-upstream-wtv5nkptcbiimz25adtalt6qnxjrasso
  Stage: 8.69s.  Edit: 0.00s.  Build: 1m 19.30s.  Install: 0.02s.  Post-install: 0.09s.  Total: 1m 28.19s
[+] /opt/release/linux-rocky8-x86_64/intel-2021.10.0/oasis3-mct-upstream-wtv5nkptcbiimz25adtalt6qnxjrasso

[root@c54cdf8658a5 oasis3-mct-upstream-wtv5nkptcbiimz25adtalt6qnxjrasso]# find include/ lib/ | sort 
include/
include/mct
include/mct/m_accumulator.mod
include/mct/m_accumulatorcomms.mod
include/mct/m_attrvect.mod
include/mct/m_attrvectcomms.mod
include/mct/m_attrvectreduce.mod
include/mct/m_chars.mod
include/mct/m_convertmaps.mod
include/mct/m_die.mod
include/mct/m_dropdead.mod
include/mct/m_exchangemaps.mod
include/mct/m_fccomms.mod
include/mct/m_filename.mod
include/mct/m_fileresolv.mod
include/mct/m_flow.mod
include/mct/m_generalgrid.mod
include/mct/m_generalgridcomms.mod
include/mct/m_globalmap.mod
include/mct/m_globalsegmap.mod
include/mct/m_globalsegmapcomms.mod
include/mct/m_globaltolocal.mod
include/mct/m_indexbin_char.mod
include/mct/m_indexbin_integer.mod
include/mct/m_indexbin_logical.mod
include/mct/m_inpak90.mod
include/mct/m_ioutil.mod
include/mct/m_list.mod
include/mct/m_mall.mod
include/mct/m_matattrvectmul.mod
include/mct/m_mctworld.mod
include/mct/m_merge.mod
include/mct/m_mergesorts.mod
include/mct/m_mpif.mod
include/mct/m_mpif90.mod
include/mct/m_mpout.mod
include/mct/m_navigator.mod
include/mct/m_permuter.mod
include/mct/m_rankmerge.mod
include/mct/m_realkinds.mod
include/mct/m_rearranger.mod
include/mct/m_router.mod
include/mct/m_sortingtools.mod
include/mct/m_sparsematrix.mod
include/mct/m_sparsematrixcomms.mod
include/mct/m_sparsematrixdecomp.mod
include/mct/m_sparsematrixplus.mod
include/mct/m_sparsematrixtomaps.mod
include/mct/m_spatialintegral.mod
include/mct/m_spatialintegralv.mod
include/mct/m_spmdutils.mod
include/mct/m_stdio.mod
include/mct/m_string.mod
include/mct/m_strtemplate.mod
include/mct/m_traceback.mod
include/mct/m_transfer.mod
include/mct/m_zeit.mod
include/mct/mct_mod.mod
include/mpeu
include/psmile.MPI1
include/psmile.MPI1/mod_oasis.mod
include/psmile.MPI1/mod_oasis_advance.mod
include/psmile.MPI1/mod_oasis_auxiliary_routines.mod
include/psmile.MPI1/mod_oasis_coupler.mod
include/psmile.MPI1/mod_oasis_data.mod
include/psmile.MPI1/mod_oasis_getput_interface.mod
include/psmile.MPI1/mod_oasis_grid.mod
include/psmile.MPI1/mod_oasis_io.mod
include/psmile.MPI1/mod_oasis_ioshr.mod
include/psmile.MPI1/mod_oasis_kinds.mod
include/psmile.MPI1/mod_oasis_load_balancing.mod
include/psmile.MPI1/mod_oasis_map.mod
include/psmile.MPI1/mod_oasis_mem.mod
include/psmile.MPI1/mod_oasis_method.mod
include/psmile.MPI1/mod_oasis_mpi.mod
include/psmile.MPI1/mod_oasis_namcouple.mod
include/psmile.MPI1/mod_oasis_parameters.mod
include/psmile.MPI1/mod_oasis_part.mod
include/psmile.MPI1/mod_oasis_reprosum.mod
include/psmile.MPI1/mod_oasis_string.mod
include/psmile.MPI1/mod_oasis_sys.mod
include/psmile.MPI1/mod_oasis_timer.mod
include/psmile.MPI1/mod_oasis_var.mod
include/psmile.MPI1/mod_prism.mod
include/scrip
include/scrip/constants.mod
include/scrip/fracnnei_mod.mod
include/scrip/grids.mod
include/scrip/iounits.mod
include/scrip/kinds_mod.mod
include/scrip/mod_oasis_flush.mod
include/scrip/netcdf_mod.mod
include/scrip/remap_bi_interp.mod
include/scrip/remap_bicubic_reduced.mod
include/scrip/remap_conservative.mod
include/scrip/remap_distance_gaussian_weight.mod
include/scrip/remap_locc_weight.mod
include/scrip/remap_vars.mod
include/scrip/remap_write.mod
include/scrip/timers.mod
lib/
lib/libmct.a
lib/libmpeu.a
lib/libpsmile.MPI1.a
lib/libscrip.a
lib/pkgconfig
lib/pkgconfig/oasis3-mct.pc
lib/pkgconfig/oasis3-mpeu.pc
lib/pkgconfig/oasis3-psmile.MPI1.pc
lib/pkgconfig/oasis3-scrip.pc

@harshula
Copy link
Copy Markdown
Collaborator Author

harshula commented Aug 27, 2025

Testing @access-om2

# spack install --keep-stage oasis3-mct@access-om2 target=x86_64 %intel@2021.10.0
...
==> Installing oasis3-mct-access-om2-5ngoyzasbx5a47z3etsnp7qsnrvvwqm4 [32/32]
==> No binary for oasis3-mct-access-om2-5ngoyzasbx5a47z3etsnp7qsnrvvwqm4 found: installing from source
==> No patches needed for oasis3-mct
==> oasis3-mct: Executing phase: 'edit'
==> oasis3-mct: Executing phase: 'build'
==> oasis3-mct: Executing phase: 'install'
==> oasis3-mct: Successfully installed oasis3-mct-access-om2-5ngoyzasbx5a47z3etsnp7qsnrvvwqm4
  Stage: 2.68s.  Edit: 0.00s.  Build: 1m 1.40s.  Install: 0.02s.  Post-install: 0.08s.  Total: 1m 4.27s
[+] /opt/release/linux-rocky8-x86_64/intel-2021.10.0/oasis3-mct-access-om2-5ngoyzasbx5a47z3etsnp7qsnrvvwqm4

[root@c54cdf8658a5 oasis3-mct-access-om2-5ngoyzasbx5a47z3etsnp7qsnrvvwqm4]# find include/ lib/ | sort 
include/
include/mct
include/mct/m_accumulator.mod
include/mct/m_accumulatorcomms.mod
include/mct/m_attrvect.mod
include/mct/m_attrvectcomms.mod
include/mct/m_attrvectreduce.mod
include/mct/m_chars.mod
include/mct/m_convertmaps.mod
include/mct/m_die.mod
include/mct/m_dropdead.mod
include/mct/m_errorhandler.mod
include/mct/m_exchangemaps.mod
include/mct/m_fccomms.mod
include/mct/m_filename.mod
include/mct/m_fileresolv.mod
include/mct/m_flow.mod
include/mct/m_generalgrid.mod
include/mct/m_generalgridcomms.mod
include/mct/m_globalmap.mod
include/mct/m_globalsegmap.mod
include/mct/m_globalsegmapcomms.mod
include/mct/m_globaltolocal.mod
include/mct/m_indexbin_char.mod
include/mct/m_indexbin_integer.mod
include/mct/m_indexbin_logical.mod
include/mct/m_inpak90.mod
include/mct/m_ioutil.mod
include/mct/m_list.mod
include/mct/m_mall.mod
include/mct/m_matattrvectmul.mod
include/mct/m_mctworld.mod
include/mct/m_merge.mod
include/mct/m_mergesorts.mod
include/mct/m_mpif.mod
include/mct/m_mpif90.mod
include/mct/m_mpout.mod
include/mct/m_navigator.mod
include/mct/m_permuter.mod
include/mct/m_rankmerge.mod
include/mct/m_realkinds.mod
include/mct/m_rearranger.mod
include/mct/m_router.mod
include/mct/m_sortingtools.mod
include/mct/m_sparsematrix.mod
include/mct/m_sparsematrixcomms.mod
include/mct/m_sparsematrixdecomp.mod
include/mct/m_sparsematrixplus.mod
include/mct/m_sparsematrixtomaps.mod
include/mct/m_spatialintegral.mod
include/mct/m_spatialintegralv.mod
include/mct/m_stdio.mod
include/mct/m_string.mod
include/mct/m_strtemplate.mod
include/mct/m_traceback.mod
include/mct/m_transfer.mod
include/mct/m_zeit.mod
include/mct/mct_mod.mod
include/mpeu
include/psmile.MPI1
include/psmile.MPI1/mod_oasis.mod
include/psmile.MPI1/mod_oasis_advance.mod
include/psmile.MPI1/mod_oasis_coupler.mod
include/psmile.MPI1/mod_oasis_data.mod
include/psmile.MPI1/mod_oasis_getput_interface.mod
include/psmile.MPI1/mod_oasis_grid.mod
include/psmile.MPI1/mod_oasis_io.mod
include/psmile.MPI1/mod_oasis_ioshr.mod
include/psmile.MPI1/mod_oasis_kinds.mod
include/psmile.MPI1/mod_oasis_method.mod
include/psmile.MPI1/mod_oasis_mpi.mod
include/psmile.MPI1/mod_oasis_namcouple.mod
include/psmile.MPI1/mod_oasis_parameters.mod
include/psmile.MPI1/mod_oasis_part.mod
include/psmile.MPI1/mod_oasis_string.mod
include/psmile.MPI1/mod_oasis_sys.mod
include/psmile.MPI1/mod_oasis_timer.mod
include/psmile.MPI1/mod_oasis_var.mod
include/psmile.MPI1/mod_prism.mod
include/scrip
include/scrip/constants.mod
include/scrip/grids.mod
include/scrip/iounits.mod
include/scrip/kinds_mod.mod
include/scrip/mod_oasis_flush.mod
include/scrip/netcdf_mod.mod
include/scrip/remap_bicubic.mod
include/scrip/remap_bicubic_reduced.mod
include/scrip/remap_bilinear.mod
include/scrip/remap_bilinear_reduced.mod
include/scrip/remap_conservative.mod
include/scrip/remap_distance_weight.mod
include/scrip/remap_gaussian_weight.mod
include/scrip/remap_vars.mod
include/scrip/remap_write.mod
include/scrip/timers.mod
lib/
lib/libmct.a
lib/libmpeu.a
lib/libpsmile.MPI1.a
lib/libscrip.a
lib/pkgconfig
lib/pkgconfig/oasis3-mct.pc
lib/pkgconfig/oasis3-mpeu.pc
lib/pkgconfig/oasis3-psmile.MPI1.pc
lib/pkgconfig/oasis3-scrip.pc

@manodeep
Copy link
Copy Markdown
Collaborator

manodeep commented Aug 27, 2025

@harshula This looks great! Will you please test that the upstream install works with oneapi@2025.2.0?

One missing feature here is the +shared variant for upstream but that can be added later on.

@harshula
Copy link
Copy Markdown
Collaborator Author

harshula commented Aug 28, 2025

Testing @upstream %oneapi@2025.2.0

This was trickier than I expected. In order for the oneapi@2025.2.0 compiler to build all the dependencies, I needed to use an environment:

[test-oasis3-upstream] [root@f385d4ca8e58 spack-packages]# cat ../environments/test-oasis3-upstream/spack.yaml 
# This is a Spack Environment file.
#
# It describes a set of packages to be installed, along with
# configuration settings.
spack:
  # add package specs to the `specs` list
  specs:
  - oasis3-mct@upstream
  packages:
    gcc-runtime:
      require:
        - '%gcc'
    all:
      require:
        - '%oneapi@2025.2.0'
        - 'target=x86_64'
  view: true
  concretizer:
    unify: true

[test-oasis3-upstream] [root@f385d4ca8e58 spack-packages]# spack install
...
==> Installing oasis3-mct-upstream-7p7hpp453vozu6xk3r6svlnu42mbhkip [52/52]
==> No binary for oasis3-mct-upstream-7p7hpp453vozu6xk3r6svlnu42mbhkip found: installing from source
==> No patches needed for oasis3-mct
==> oasis3-mct: Executing phase: 'edit'
==> oasis3-mct: Executing phase: 'build'
==> oasis3-mct: Executing phase: 'install'
==> oasis3-mct: Successfully installed oasis3-mct-upstream-7p7hpp453vozu6xk3r6svlnu42mbhkip
  Stage: 9.04s.  Edit: 0.00s.  Build: 49.93s.  Install: 0.02s.  Post-install: 0.08s.  Total: 59.15s
[+] /opt/release/linux-rocky8-x86_64/oneapi-2025.2.0/oasis3-mct-upstream-7p7hpp453vozu6xk3r6svlnu42mbhkip
==> Updating view at /opt/environments/test-oasis3-upstream/.spack-env/view

[test-oasis3-upstream] [root@f385d4ca8e58 spack-packages]# spack find
==> In environment test-oasis3-upstream
==> 1 root specs
[+] oasis3-mct@upstream

==> Installed packages
-- linux-rocky8-x86_64 / gcc@8.5.0 ------------------------------
gcc-runtime@8.5.0

-- linux-rocky8-x86_64 / oneapi@2025.2.0 ------------------------
autoconf@2.72                       libxcrypt@4.4.35
automake@1.16.5                     libxml2@2.10.3
bzip2@1.0.8                         lz4@1.9.4
c-blosc@1.21.5                      m4@1.4.19
ca-certificates-mozilla@2023-05-30  mpich@4.2.1
cmake@3.31.6                        ncurses@6.5
curl@8.7.1                          netcdf-c@4.9.2
diffutils@3.10                      netcdf-fortran@4.6.1
expat@2.6.2                         nghttp2@1.57.0
findutils@4.9.0                     oasis3-mct@upstream
gdbm@1.23                           openssl@3.3.0
gettext@0.22.5                      perl@5.26.3
glibc@2.28                          pigz@2.8
gmake@4.4.1                         pkgconf@2.2.0
hdf5@1.14.3                         python@3.11.7
hwloc@2.9.1                         readline@8.2
intel-oneapi-runtime@2025.2.0       snappy@1.1.10
libaec@1.0.6                        sqlite@3.43.2
libbsd@0.12.1                       tar@1.34
libfabric@1.21.0                    util-linux-uuid@2.38.1
libffi@3.4.6                        util-macros@1.19.3
libiconv@1.17                       xz@5.4.6
libmd@1.0.4                         yaksa@0.3
libpciaccess@0.17                   zlib-ng@2.1.6
libsigsegv@2.14                     zstd@1.5.6
libtool@2.4.6
==> 52 installed packages

[test-oasis3-upstream] [root@f385d4ca8e58 oasis3-mct-upstream-7p7hpp453vozu6xk3r6svlnu42mbhkip]# find include/ lib/ | sort
include/
include/mct
include/mct/m_accumulator.mod
include/mct/m_accumulatorcomms.mod
include/mct/m_attrvect.mod
include/mct/m_attrvectcomms.mod
include/mct/m_attrvectreduce.mod
include/mct/m_chars.mod
include/mct/m_convertmaps.mod
include/mct/m_die.mod
include/mct/m_dropdead.mod
include/mct/m_exchangemaps.mod
include/mct/m_fccomms.mod
include/mct/m_filename.mod
include/mct/m_fileresolv.mod
include/mct/m_flow.mod
include/mct/m_generalgrid.mod
include/mct/m_generalgridcomms.mod
include/mct/m_globalmap.mod
include/mct/m_globalsegmap.mod
include/mct/m_globalsegmapcomms.mod
include/mct/m_globaltolocal.mod
include/mct/m_indexbin_char.mod
include/mct/m_indexbin_integer.mod
include/mct/m_indexbin_logical.mod
include/mct/m_inpak90.mod
include/mct/m_ioutil.mod
include/mct/m_list.mod
include/mct/m_mall.mod
include/mct/m_matattrvectmul.mod
include/mct/m_mctworld.mod
include/mct/m_merge.mod
include/mct/m_mergesorts.mod
include/mct/m_mpif.mod
include/mct/m_mpif90.mod
include/mct/m_mpout.mod
include/mct/m_navigator.mod
include/mct/m_permuter.mod
include/mct/m_rankmerge.mod
include/mct/m_realkinds.mod
include/mct/m_rearranger.mod
include/mct/m_router.mod
include/mct/m_sortingtools.mod
include/mct/m_sparsematrix.mod
include/mct/m_sparsematrixcomms.mod
include/mct/m_sparsematrixdecomp.mod
include/mct/m_sparsematrixplus.mod
include/mct/m_sparsematrixtomaps.mod
include/mct/m_spatialintegral.mod
include/mct/m_spatialintegralv.mod
include/mct/m_spmdutils.mod
include/mct/m_stdio.mod
include/mct/m_string.mod
include/mct/m_strtemplate.mod
include/mct/m_traceback.mod
include/mct/m_transfer.mod
include/mct/m_zeit.mod
include/mct/mct_mod.mod
include/mpeu
include/psmile.MPI1
include/psmile.MPI1/mod_oasis.mod
include/psmile.MPI1/mod_oasis_advance.mod
include/psmile.MPI1/mod_oasis_auxiliary_routines.mod
include/psmile.MPI1/mod_oasis_coupler.mod
include/psmile.MPI1/mod_oasis_data.mod
include/psmile.MPI1/mod_oasis_getput_interface.mod
include/psmile.MPI1/mod_oasis_grid.mod
include/psmile.MPI1/mod_oasis_io.mod
include/psmile.MPI1/mod_oasis_ioshr.mod
include/psmile.MPI1/mod_oasis_kinds.mod
include/psmile.MPI1/mod_oasis_load_balancing.mod
include/psmile.MPI1/mod_oasis_map.mod
include/psmile.MPI1/mod_oasis_mem.mod
include/psmile.MPI1/mod_oasis_method.mod
include/psmile.MPI1/mod_oasis_mpi.mod
include/psmile.MPI1/mod_oasis_namcouple.mod
include/psmile.MPI1/mod_oasis_parameters.mod
include/psmile.MPI1/mod_oasis_part.mod
include/psmile.MPI1/mod_oasis_reprosum.mod
include/psmile.MPI1/mod_oasis_string.mod
include/psmile.MPI1/mod_oasis_sys.mod
include/psmile.MPI1/mod_oasis_timer.mod
include/psmile.MPI1/mod_oasis_var.mod
include/psmile.MPI1/mod_prism.mod
include/scrip
include/scrip/constants.mod
include/scrip/fracnnei_mod.mod
include/scrip/grids.mod
include/scrip/iounits.mod
include/scrip/kinds_mod.mod
include/scrip/mod_oasis_flush.mod
include/scrip/netcdf_mod.mod
include/scrip/remap_bi_interp.mod
include/scrip/remap_bicubic_reduced.mod
include/scrip/remap_conservative.mod
include/scrip/remap_distance_gaussian_weight.mod
include/scrip/remap_locc_weight.mod
include/scrip/remap_vars.mod
include/scrip/remap_write.mod
include/scrip/timers.mod
lib/
lib/libmct.a
lib/libmpeu.a
lib/libpsmile.MPI1.a
lib/libscrip.a
lib/pkgconfig
lib/pkgconfig/oasis3-mct.pc
lib/pkgconfig/oasis3-mpeu.pc
lib/pkgconfig/oasis3-psmile.MPI1.pc
lib/pkgconfig/oasis3-scrip.pc

@harshula harshula mentioned this pull request Aug 28, 2025
Closed
@harshula harshula moved this to In Progress in ACCESS-OM2 Spack Aug 28, 2025
@manodeep
Copy link
Copy Markdown
Collaborator

manodeep commented Aug 28, 2025

I could also install um7 with oasis3-mct@upstream + oneAPI@2025.2.0 and openmpi@5.0.5. However, I got a concretization failure with when trying to install mom5@git.2025.05.000=access-esm1.6 %oneapi@2025.2.0 ^openmpi@5.0.5 ^oasis3-mct@upstream --

==> Error: concretization failed for the following reasons:

   1. Cannot select a single "version" for package "oasis3-mct"
   2. Cannot satisfy 'oasis3-mct@upstream'
   3. Cannot satisfy 'oasis3-mct@access-esm1.5'
   4. Cannot satisfy 'oasis3-mct@:access-esm0,access-esm2:'
   5. Cannot satisfy 'oasis3-mct@upstream'
        required because mom5@git.2025.05.000=access-esm1.6%oneapi@2025.2.0 ^oasis3-mct@upstream ^openmpi@5.0.5 requested explicitly 
   6. Cannot satisfy 'oasis3-mct@access-esm1.5'
        required because mom5 depends on oasis3-mct@access-esm1.5~deterministic when @access-esm1.6~deterministic 
          required because mom5@git.2025.05.000=access-esm1.6%oneapi@2025.2.0 ^oasis3-mct@upstream ^openmpi@5.0.5 requested explicitly 
   7. Cannot satisfy 'oasis3-mct@upstream' and 'oasis3-mct@access-esm1.5
        required because mom5@git.2025.05.000=access-esm1.6%oneapi@2025.2.0 ^oasis3-mct@upstream ^openmpi@5.0.5 requested explicitly 
        required because mom5 depends on oasis3-mct@access-esm1.5~deterministic when @access-esm1.6~deterministic 
          required because mom5@git.2025.05.000=access-esm1.6%oneapi@2025.2.0 ^oasis3-mct@upstream ^openmpi@5.0.5 requested explicitly 
   8. Cannot satisfy 'oasis3-mct@access-esm1.5' and 'oasis3-mct@upstream
        required because mom5@git.2025.05.000=access-esm1.6%oneapi@2025.2.0 ^oasis3-mct@upstream ^openmpi@5.0.5 requested explicitly 
        required because mom5 depends on oasis3-mct@access-esm1.5~deterministic when @access-esm1.6~deterministic 
          required because mom5@git.2025.05.000=access-esm1.6%oneapi@2025.2.0 ^oasis3-mct@upstream ^openmpi@5.0.5 requested explicitly

Which is presumably happening because these lines set the oasis3-mct version to access-esm1.5 when mom5@access-esm1.6 is requested.

@harshula
Copy link
Copy Markdown
Collaborator Author

harshula commented Aug 28, 2025

Hi @manodeep , That should be resolved when #311 is merged.

dougiesquire
dougiesquire reviewed Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great @harshula! One question, probably for @manodeep

Comment thread packages/oasis3-mct/package.py
manodeep
manodeep reviewed Aug 29, 2025
View reviewed changes
Comment thread packages/oasis3-mct/package.py Outdated
manodeep
manodeep previously approved these changes Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@manodeep manodeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a minor comment about the version number since we are using the dev-branch, but the changes looks good to me

dougiesquire
dougiesquire previously approved these changes Aug 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @harshula

@harshula
oasis3-mct: add upstream version()
8f9e74e 
* Remove static list of Fortran module files.
* Remove function __init__().
* Simplify install().
@harshula harshula dismissed stale reviews from dougiesquire and manodeep via 8f9e74e September 1, 2025 00:11
@harshula harshula force-pushed the add-oasis3-mct-upstream-version branch from c2f11b0 to 8f9e74e Compare September 1, 2025 00:11
manodeep
manodeep reviewed Sep 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@manodeep manodeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshula The only change I noticed was for the version 5.0 -> 5 - was there anything else?

@harshula harshula merged commit 867678b into main Sep 1, 2025
3 of 4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in ACCESS-OM2 Spack Sep 1, 2025
@harshula harshula deleted the add-oasis3-mct-upstream-version branch September 1, 2025 00:47
@manodeep manodeep mentioned this pull request Sep 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manodeep manodeep manodeep left review comments

@dougiesquire dougiesquire dougiesquire approved these changes

@penguian penguian Awaiting requested review from penguian

@blimlim blimlim Awaiting requested review from blimlim

@aidanheerdegen aidanheerdegen Awaiting requested review from aidanheerdegen

Assignees

@harshula harshula

Labels

None yet

Projects

ACCESS-ESM1.5 Spack
Status: Done
ACCESS-ESM1.6
Archived in project
ACCESS-OM2 Spack
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harshula @manodeep @dougiesquire
⚡