expose ice_ref_salinity to the namelist#36
Merged
anton-seaice merged 3 commits intoaccess-esm1.6from Jun 4, 2025
Merged
Conversation
Collaborator
Author
|
Contributes to #32 |
dougiesquire
reviewed
Jun 3, 2025
| Lfresh = Lsub-Lvap ,&! latent heat of melting of fresh ice (J/kg) | ||
| Timelt = 0.0_dbl_kind ,&! melting temperature, ice top surface (C) | ||
| Tsmelt = 0.0_dbl_kind ,&! melting temperature, snow top surface (C) | ||
| ice_ref_salinity = 5._dbl_kind, &!8._dbl_kind ,&! (ppt) |
There was a problem hiding this comment.
I think this still needs to be defined inside an #ifndef AusCOM?
| Tocnfrz ! freezing temp of seawater (C), | ||
| Tocnfrz , &! freezing temp of seawater (C), | ||
| ! used as Tsfcn for open water | ||
| ice_ref_salinity ! (ppt) |
There was a problem hiding this comment.
Is it worth adding a comment with a description of the variable?
E.g.
Suggested change
| ice_ref_salinity ! (ppt) | |
| ice_ref_salinity ! reference salinity for ice–ocean exchanges (ppt) |
Collaborator
Author
|
I made some refinements @dougiesquire - let me know |
dougiesquire
reviewed
Jun 4, 2025
| !ars599: 26032014: change to public | ||
| !ars599: 24042015: remove dragio!! | ||
| #endif | ||
| #ifndef AusCOM |
There was a problem hiding this comment.
Given you're now rearranging things, can this and the prior ifndef blocks be consolidated from:
#ifndef AusCOM
! multilayers with the UM coupling
aicenmin_ml = 0.00001_dbl_kind, &! AEW: min aice we want to allow when using
snowpatch = 0.02_dbl_kind, & ! parameter for fractional snow area (m)
#else
aicenmin_ml = 0.00001_dbl_kind! AEW: min aice we want to allow when using
#endif
#ifndef AusCOM
!!! dragio = 0.00536_dbl_kind ,&! ice-ocn drag coefficient
dragio = 0.01_dbl_kind ,&!!! 20170922 test new value as per spo
Tocnfrz = -1.8_dbl_kind ,&! freezing temp of seawater (C),
! used as Tsfcn for open water
ice_ref_salinity = 5._dbl_kind ! reference salinity for ice–ocean exchanges (ppt)
! n.b. CICE6 uses 4 ppt
#else
! get these in ice_init from namelist
real (kind=dbl_kind), public :: &
dragio , & ! ice-ocn drag coefficient
Tocnfrz , & ! freezing temp of seawater (C),
! used as Tsfcn for open water
ice_ref_salinity ! reference salinity for ice–ocean exchanges (ppt)
#endifto:
! multilayers with the UM coupling
aicenmin_ml = 0.00001_dbl_kind ! AEW: min aice we want to allow when using
#ifndef AusCOM
real (kind=dbl_kind), parameter, public :: &
snowpatch = 0.02_dbl_kind, & ! parameter for fractional snow area (m)
!!! dragio = 0.00536_dbl_kind ,&! ice-ocn drag coefficient
dragio = 0.01_dbl_kind ,&!!! 20170922 test new value as per spo
Tocnfrz = -1.8_dbl_kind ,&! freezing temp of seawater (C),
! used as Tsfcn for open water
ice_ref_salinity = 5._dbl_kind ! reference salinity for ice–ocean exchanges (ppt)
! n.b. CICE6 uses 4 ppt
#else
! get these in ice_init from namelist
real (kind=dbl_kind), public :: &
dragio , & ! ice-ocn drag coefficient
Tocnfrz , & ! freezing temp of seawater (C),
! used as Tsfcn for open water
ice_ref_salinity ! reference salinity for ice–ocean exchanges (ppt)
#endif
Collaborator
Author
There was a problem hiding this comment.
I liked having the dragio / TocnFx / ice_ref_salinity in adjacent lines ?
There was a problem hiding this comment.
I mostly have an issue (issue is an overstatement) with aicenmin_ml = 0.00001_dbl_kind being in both clauses. What about:
! multilayers with the UM coupling
aicenmin_ml = 0.00001_dbl_kind ! AEW: min aice we want to allow when using
#ifndef AusCOM
real (kind=dbl_kind), parameter, public :: &
snowpatch = 0.02_dbl_kind ! parameter for fractional snow area (m)
#endif
#ifndef AusCOM
real (kind=dbl_kind), parameter, public :: &
!!! dragio = 0.00536_dbl_kind ,&! ice-ocn drag coefficient
dragio = 0.01_dbl_kind ,&!!! 20170922 test new value as per spo
Tocnfrz = -1.8_dbl_kind ,&! freezing temp of seawater (C),
! used as Tsfcn for open water
ice_ref_salinity = 5._dbl_kind ! reference salinity for ice–ocean exchanges (ppt)
! n.b. CICE6 uses 4 ppt
#else
! get these in ice_init from namelist
real (kind=dbl_kind), public :: &
dragio , & ! ice-ocn drag coefficient
Tocnfrz , & ! freezing temp of seawater (C),
! used as Tsfcn for open water
ice_ref_salinity ! reference salinity for ice–ocean exchanges (ppt)
#endifThis isn't particularly nice either. If you resist this in any way I will yield and approve 🙂
Collaborator
Author
|
back to you @dougiesquire |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the assumed salinity of sea ice configurable, so we can set it the same as the MOM value
(configured in MOM here)
We use 4ppt in MOM for historical reasons, and did that in CICE4 too.