Skip to content

only couple bgc when bgc is active#79

Merged
anton-seaice merged 3 commits intomasterfrom
75
Dec 1, 2025
Merged

only couple bgc when bgc is active#79
anton-seaice merged 3 commits intomasterfrom
75

Conversation

@anton-seaice
Copy link
Copy Markdown
Collaborator

@anton-seaice anton-seaice commented Nov 26, 2025

I tested this with a Debug build, and it now runs without error :)

Closes #75

@anton-seaice anton-seaice self-assigned this Nov 26, 2025
@anton-seaice anton-seaice marked this pull request as ready for review November 26, 2025 04:17
Copy link
Copy Markdown

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anton-seaice. Possibly worth also avoiding doing the accumulation when skl_bgc = .false.:

-    ionit (:,:,:)  = ionit (:,:,:) + tionit (:,:,:)*coef_ic
-    ioalg (:,:,:)  = ioalg (:,:,:) + tioalg (:,:,:)*coef_ic
+    if (skl_bgc) then
+        ionit (:,:,:)  = ionit (:,:,:) + tionit (:,:,:)*coef_ic
+        ioalg (:,:,:)  = ioalg (:,:,:) + tioalg (:,:,:)*coef_ic
+    endif

@anton-seaice
Copy link
Copy Markdown
Collaborator Author

Implemented the suggestion @dougiesquire

Copy link
Copy Markdown

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anton-seaice

@anton-seaice anton-seaice merged commit 38b7fc8 into master Dec 1, 2025
4 checks passed
@anton-seaice anton-seaice deleted the 75 branch December 1, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CICE5 BGC

2 participants