Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 75.18% 74.17% -1.01%
==========================================
Files 18 18
Lines 927 945 +18
==========================================
+ Hits 697 701 +4
- Misses 230 244 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dougiesquire
requested changes
Mar 18, 2025
Collaborator
dougiesquire
left a comment
There was a problem hiding this comment.
Thanks @blimlim! Sorry for taking so long - got sucked into a meeting
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
Collaborator
Author
|
Thanks @dougiesquire and not a problem at all! Good point with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133.
This PR updates the QA tests for ESM1.6. Previously, the
test_mppnccombine_fast_collate_exetest checked that the collation executable and mpi setting were correctly set.ACCESS-NRI/access-esm1.6-configs#55 removed collation for the configuration, and set
io_layout=1,1in the oceaninput.nmlfile. These two changes are linked, and are required to go together (i.e. switching off collation only makes sense if you haveio_layout=1,1. Because of this, I've modified the tests to check that collation is disabled and correctio_layoutis set.Any feedback or suggestions are very welcome!