Skip to content

ESM1.6 qa checks for io_layout#134

Merged
blimlim merged 4 commits intomainfrom
133-esm-collation
Mar 18, 2025
Merged

ESM1.6 qa checks for io_layout#134
blimlim merged 4 commits intomainfrom
133-esm-collation

Conversation

@blimlim
Copy link
Copy Markdown
Collaborator

@blimlim blimlim commented Mar 18, 2025

Closes #133.

This PR updates the QA tests for ESM1.6. Previously, the test_mppnccombine_fast_collate_exe test checked that the collation executable and mpi setting were correctly set.

ACCESS-NRI/access-esm1.6-configs#55 removed collation for the configuration, and set io_layout=1,1 in the ocean input.nml file. These two changes are linked, and are required to go together (i.e. switching off collation only makes sense if you have io_layout=1,1. Because of this, I've modified the tests to check that collation is disabled and correct io_layout is set.

Any feedback or suggestions are very welcome!

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 21.73913% with 18 lines in your changes missing coverage. Please review.

Project coverage is 74.17%. Comparing base (4c4de2d) to head (2dce9f0).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...model_config_tests/qa/test_access_esm1p6_config.py 21.73% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   75.18%   74.17%   -1.01%     
==========================================
  Files          18       18              
  Lines         927      945      +18     
==========================================
+ Hits          697      701       +4     
- Misses        230      244      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blimlim! Sorry for taking so long - got sucked into a meeting

Comment thread src/model_config_tests/qa/test_access_esm1p6_config.py
Comment thread src/model_config_tests/qa/test_access_esm1p6_config.py Outdated
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
@blimlim
Copy link
Copy Markdown
Collaborator Author

blimlim commented Mar 18, 2025

Thanks @dougiesquire and not a problem at all! Good point with the str(i) change. From what I can tell, I think I need to keep the explicit check that ["collation"]["enable"] is False. I could add an extra check to make sure the [enable] flag is present too. Let me know what you think!

@blimlim blimlim requested a review from dougiesquire March 18, 2025 05:58
Copy link
Copy Markdown
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blimlim!

@blimlim blimlim merged commit 32612ab into main Mar 18, 2025
6 of 8 checks passed
@blimlim blimlim deleted the 133-esm-collation branch March 18, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow collation to be disabled for ESM1.6 qa tests

2 participants