Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 81.49% 81.58% +0.09%
==========================================
Files 20 20
Lines 1194 1200 +6
==========================================
+ Hits 973 979 +6
Misses 221 221 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jo-basevi
force-pushed
the
extra-access-om2-metadata-checks
branch
from
4d23602 to
b24e637
Compare
jo-basevi
force-pushed
the
extra-access-om2-metadata-checks
branch
from
b24e637 to
b58c406
Compare
Contributor
Author
|
Updated the expected metadata notes based on review suggestions in ACCESS-NRI/access-om2-configs#175 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds QA tests for the metadata to check if model name is set as expected using the resolution of the target branch (ACCESS-NRI/access-om2-configs#141), and that notes which have the conditions of use are set (ACCESS-NRI/access-om2-configs#165).
Will leave this in draft until expected
modelnames are confirmed.