Skip to content

ACCESS-OM2 QA checks: Only expect ACCESS-OM2-BGC for old BGC configs#205

Merged
dougiesquire merged 1 commit intomainfrom
203-om2-qa-bgc
Mar 16, 2026
Merged

ACCESS-OM2 QA checks: Only expect ACCESS-OM2-BGC for old BGC configs#205
dougiesquire merged 1 commit intomainfrom
203-om2-qa-bgc

Conversation

@dougiesquire
Copy link
Copy Markdown
Collaborator

Sorry @jo-basevi, I rushed this the first time and missed the module and repo name checks:

The behaviour should be:

  • if "bgc" is in the config name: use ACCESS-OM2-BGC (now-deprecated)
  • if "wombat" is in the config name: use ACCESS-OM2

@dougiesquire dougiesquire requested a review from jo-basevi March 16, 2026 02:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.67%. Comparing base (b881d91) to head (b000080).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #205       +/-   ##
===========================================
+ Coverage   68.39%   85.67%   +17.28%     
===========================================
  Files          14       22        +8     
  Lines         829     1243      +414     
===========================================
+ Hits          567     1065      +498     
+ Misses        262      178       -84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM

@dougiesquire dougiesquire merged commit 2fd633d into main Mar 16, 2026
8 checks passed
@dougiesquire dougiesquire deleted the 203-om2-qa-bgc branch March 16, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants