Skip to content

Remove test configurations in tests/resources#212

Open
Qian-HuiChen wants to merge 1 commit intomainfrom
117-remove-test-config
Open

Remove test configurations in tests/resources#212
Qian-HuiChen wants to merge 1 commit intomainfrom
117-remove-test-config

Conversation

@Qian-HuiChen
Copy link
Copy Markdown
Contributor

Remove all configurations stored in tests/resources which are used in unit testing.

Instead, on-demand cloning is called via git clone during unit test execution and cleaned up after the unit tests. A fixed commit hash is currently hard-coded in tests/common.py to ensure reproducibility and version control.

Closes #117.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.38%. Comparing base (82e5c81) to head (9595035).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files          22       22           
  Lines        1300     1300           
=======================================
  Hits         1110     1110           
  Misses        190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this @Qian-HuiChen. It is nice to see so many deleted files :)

As the cloned configurations are used in several tests, an option could be to have a session-scoped fixture that creates a cache of the cloned configurations. Then a test-scoped fixture that copies the clone to a tmp directory, and then cleans up the directory after. This might run faster than cloning for every test.

Comment thread tests/common.py
Comment on lines +13 to +19
"file_list": [
"manifests/",
"config.yaml",
"accessom2.nml",
"metadata.yaml",
"LICENSE",
],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll be ok to clone all the files in the configurations to make it simpler. I think a subset was only to saved to the repository's test resources previously to avoid saving too many files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove test configurations in tests/resources?

2 participants