Remove test configurations in tests/resources#212
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 22 22
Lines 1300 1300
=======================================
Hits 1110 1110
Misses 190 190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a3a0fc0 to
9595035
Compare
jo-basevi
left a comment
There was a problem hiding this comment.
Thanks for implementing this @Qian-HuiChen. It is nice to see so many deleted files :)
As the cloned configurations are used in several tests, an option could be to have a session-scoped fixture that creates a cache of the cloned configurations. Then a test-scoped fixture that copies the clone to a tmp directory, and then cleans up the directory after. This might run faster than cloning for every test.
| "file_list": [ | ||
| "manifests/", | ||
| "config.yaml", | ||
| "accessom2.nml", | ||
| "metadata.yaml", | ||
| "LICENSE", | ||
| ], |
There was a problem hiding this comment.
I think it'll be ok to clone all the files in the configurations to make it simpler. I think a subset was only to saved to the repository's test resources previously to avoid saving too many files.
Remove all configurations stored in
tests/resourceswhich are used in unit testing.Instead, on-demand cloning is called via
git cloneduring unit test execution and cleaned up after the unit tests. A fixed commit hash is currently hard-coded intests/common.pyto ensure reproducibility and version control.Closes #117.