Address Copilot review comments

- Set CATCH status
- evaluate shadername in RenderItem constructor.

Author: ashwinbhat

source/MaterialXTest/MaterialXRender/RenderUtil.cpp

@@ -32,6 +32,25 @@ ShaderRenderTester::~ShaderRenderTester()
 {
 }
 
+RenderItem::RenderItem(mx::TypedElementPtr elem,
+                       mx::FileSearchPath searchPath,
+                       mx::FilePath outPath,
+                       mx::ImageVec* images)
+    : element(std::move(elem)),
+      imageSearchPath(std::move(searchPath)),
+      outputPath(std::move(outPath)),
+      imageVec(images)
+{
+    static const mx::StringMap pathMap = []() {
+        mx::StringMap m;
+        m["/"] = "_";
+        m[":"] = "_";
+        return m;
+    }();
+    shaderName = mx::createValidName(
+        mx::replaceSubstrings(element->getNamePath(), pathMap));
+}
+
 bool ShaderRenderTester::validate(const mx::FilePath optionsFilePath)
 {
     // per-run state objects, logger, profiler

source/MaterialXTest/MaterialXRender/RenderUtil.h

@@ -16,6 +16,7 @@
 #include <fstream>
 #include <iostream>
 #include <memory>
+#include <utility>
 
 #define LOG_TO_FILE
 
@@ -186,18 +187,7 @@ struct RenderItem
     RenderItem(mx::TypedElementPtr elem,
                mx::FileSearchPath searchPath,
                mx::FilePath outPath,
-               mx::ImageVec* images = nullptr)
-        : element(std::move(elem)),
-          imageSearchPath(std::move(searchPath)),
-          outputPath(std::move(outPath)),
-          imageVec(images)
-    {
-        mx::StringMap pathMap;
-        pathMap["/"] = "_";
-        pathMap[":"] = "_";
-        shaderName = mx::createValidName(
-            mx::replaceSubstrings(element->getNamePath(), pathMap));
-    }
+               mx::ImageVec* images = nullptr);
 
     mx::TypedElementPtr element;
     mx::FileSearchPath imageSearchPath;

source/MaterialXTest/MaterialXRenderGlsl/RenderGlsl.cpp

@@ -403,6 +403,8 @@ RenderUtil::RenderProfileResult GlslShaderRenderTester::runRenderer(
                 WARN(std::string(e.what()) + " in " + shaderPath);
             }
             CHECK(validated);
+            if (!validated)
+                result.success = false;
         }
     }
     return result;

source/MaterialXTest/MaterialXRenderMdl/RenderMdl.cpp

@@ -226,6 +226,8 @@ RenderUtil::RenderProfileResult MdlShaderRenderTester::runRenderer(
                 log << e.what() << "\n";
             }
             CHECK(validated);
+            if (!validated)
+                result.success = false;
         }
     }
 

source/MaterialXTest/MaterialXRenderMsl/RenderMsl.mm

@@ -400,6 +400,8 @@ void registerLights(mx::DocumentPtr document, const GenShaderUtil::TestSuiteOpti
                 WARN(std::string(e.what()) + " in " + shaderPath);
             }
             CHECK(validated);
+            if (!validated)
+                result.success = false;
         }
     }
     return result;

source/MaterialXTest/MaterialXRenderOsl/RenderOsl.cpp

@@ -372,6 +372,8 @@ RenderUtil::RenderProfileResult OslShaderRenderTester::runRenderer(
                 log << e.what();
             }
             CHECK(validated);
+            if (!validated)
+                result.success = false;
         }
     }
 

source/MaterialXTest/MaterialXRenderSlang/RenderSlang.cpp

@@ -393,6 +393,8 @@ RenderUtil::RenderProfileResult SlangShaderRenderTester::runRenderer(
                 WARN(std::string(e.what()) + " in " + shaderPath);
             }
             CHECK(validated);
+            if (!validated)
+                result.success = false;
         }
     }
     return result;