MDL 1.7 dielectric and generalized schlick improvements#1321
Merged
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom Apr 14, 2023
Conversation
…resnel because of issues with diffuse transmission
jstone-lucasfilm
approved these changes
Apr 14, 2023
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Thanks for these improvements, @krohmerNV!
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…areFoundation#1321) - Change the `Dielectric` MDL implementation to use custom curve instead of Fresnel because of issues with diffuse transmission. This comes with limited thin_film support, which will be restored by MDL 1.8 - Improve `Generalized Schlick` MDL implementation so Reflect, Transmit and ReflectTransmit are more plausible. The OSL backend produces very similar results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DielectricMDL implementation to use custom curve instead of Fresnel because of issues with diffuse transmission. This comes with limited thin_film support, which will be restored by MDL 1.8Generalized SchlickMDL implementation so Reflect, Transmit and ReflectTransmit are more plausible. The OSL backend produces very similar results.