Add integer signature to floor and ceil#1362
Merged
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom May 26, 2023
Merged
Add integer signature to floor and ceil#1362jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Contributor
Author
|
Locally it builds, but it's got some test failures because |
Member
|
This looks really promising, thanks @crydalch, and I believe we just need to add examples of these new nodes to our unit tests, since they're new primitives with their own unique source code. I should be able to help set this up, and I'll take a look when I have a moment. |
Closed
jstone-lucasfilm
approved these changes
May 26, 2023
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @crydalch!
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
Adds support to ceil and floor to output integers. There will be other tickets/discussions around improving integer support across MaterialX, but adding integer output to these nodes first would be a big help to some nodegraph contributions we'd like to contribute soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to
ceilandfloorto output integers. There will be other tickets/discussions around improving integer support across MaterialX, but adding integer output to these nodes first would be a big help to some nodegraph contributions we'd like to contribute soon.Thanks!