Fix input default values on cmlib definitions#1369
Merged
jstone-lucasfilm merged 5 commits intoAcademySoftwareFoundation:mainfrom Jun 14, 2023
Merged
Fix input default values on cmlib definitions#1369jstone-lucasfilm merged 5 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 5 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
The default value fix looks great to me, and thanks for catching this. I wonder, though, if we really want an additional test document for the color transform nodes, since they are already tested in color_management.mtlx?
In some ways, the existing tests are more comprehensive than these new ones, as they test both the functionality of each transform node and the system that injects them into material graphs.
What are your thoughts?
jstone-lucasfilm
changed the title
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…ion#1369) Fix so that cmlib inputs have default values, otherwise validate() will fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix so that
cmlibinputs have default values, otherwise validate() will fail.