Specification Updates#1371
Merged
jstone-lucasfilm merged 7 commits intoAcademySoftwareFoundation:mainfrom Jun 8, 2023
dbsmythe:main
Merged
Specification Updates#1371jstone-lucasfilm merged 7 commits intoAcademySoftwareFoundation:mainfrom dbsmythe:main
jstone-lucasfilm merged 7 commits intoAcademySoftwareFoundation:mainfrom
dbsmythe:main
Conversation
Add descriptions of checkerboard and distance nodes, clarify use of colorspace/etc attrs in <output> elements
Add note about integer output variants for floor, ceil, round
Moved/combined/renamed the three sections titled "Shader Nodes" to make more sense and not have conflicting link targets. Added other new things to the README.
formatting fixes
add "blend" param to triplanars, formatting fix
jstone-lucasfilm
approved these changes
Jun 8, 2023
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @dbsmythe!
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
Updates to the v1.39 markdown spec docs. Main Specification: - Removed the earlier "Shader Nodes" section and moved its important contents to a later existing also-named "Shader Nodes" section, cleaned up the text and node descriptions. - Added clarification paragraph to "Output Nodes" section to say that "colorspace", "width", "height" and "bitdepth" are only applicable in applications that save output images, and do not affect values output to other nodes connected to this output (Slack discussion) - Added descriptions of the new <checkerboard>, <round> and <distance> nodes. Also added note about integer-output variants of <floor> and <ceil>. - Added note that geomcolor, geompropvalue and geompropvalueuniform can take a "colorspace" attribute for color3/4 values (Slack discussion) - Removed notes on "add" and "multiply" about shader-semantic variants, because you can't actually add or multiply *shaders*, only BSDF's/EDF's/VDF's, and those are covered in the PBRSpec doc. PBRSpec: - Renamed "Shader Nodes" section to "PBR Shader Nodes" to avoid conflict with main specification heading - Added links to the "displacement" and "surface_unlit" nodes in the main Spec doc Supplement: - Added "blend" input to the triplanar nodes, as this is a "no brainer" to be added officially. - Some minor formatting fixes. README: - Updated to include new/updated nodes and a few other updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the v1.39 markdown spec docs.
Main Specification:
PBRSpec:
Supplement:
README: