Fixed Python script errors flagged by pyflakes#1604
Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Nov 27, 2023
Merged
Fixed Python script errors flagged by pyflakes#1604jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
```bash $ flake8 python/scripts --select F python/scripts/generateshader.py:28:13: F841 local variable 'result' is assigned to but never used python/scripts/generateshader.py:86:16: F821 undefined name 'err' python/scripts/generateshader.py:87:43: F821 undefined name 'err' python/scripts/genmdl.py:8:1: F401 'string' imported but unused python/scripts/genmdl.py:344:5: F841 local variable 'LIBRARY' is assigned to but never used python/scripts/genmdl.py:525:21: F841 local variable 'outputvalue' is assigned to but never used python/scripts/mxdoc.py:6:1: F401 'os' imported but unused python/scripts/mxformat.py:7:1: F401 'sys' imported but unused python/scripts/mxvalidate.py:6:1: F401 'os' imported but unused python/scripts/mxvalidate.py:28:16: F821 undefined name 'err' python/scripts/mxvalidate.py:29:19: F821 undefined name 'err' ``` With this patch: ```bash $ flake8 python/scripts --select F --count 0 ``` Found while working on AcademySoftwareFoundation#1595. This commit follows 83ae82e. Signed-off-by: Stefan Habel <19556655+StefanHabel@users.noreply.github.com>
Member
|
This looks really promising, thanks @StefanHabel! |
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Nov 27, 2023
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
These fixes look good to me, thanks @StefanHabel!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch:
Found while working on #1595.
This commit follows 83ae82e.