Skip to content

Override aggregated struct generation for MDL#2261

Merged
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
krohmerNV:krohmer/MDL-fix-aggegate-struct-syntax
Mar 10, 2025
Merged

Override aggregated struct generation for MDL#2261
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
krohmerNV:krohmer/MDL-fix-aggegate-struct-syntax

Conversation

@krohmerNV
Copy link
Copy Markdown
Contributor

Add a custom StructTypeSyntax implementation for MDL.

@krohmerNV krohmerNV force-pushed the krohmer/MDL-fix-aggegate-struct-syntax branch from fd426d0 to aa0711d Compare March 5, 2025 14:13
@jstone-lucasfilm
Copy link
Copy Markdown
Member

Thanks for this fix, @krohmerNV, and this change looks good to me.

Since this change is scoped to MDL shader generation, and it was written by the domain expert in this system, I would be inclined to see this as safe to include in our upcoming v1.39.3 release.

What are your thoughts, @ld-kerley?

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@jstone-lucasfilm
Copy link
Copy Markdown
Member

@krohmerNV It looks as if we've lost your EasyCLA approval over the last day, and let me know if you run into any trouble restoring it!

@krohmerNV
Copy link
Copy Markdown
Contributor Author

@jstone-lucasfilm is there anything you can do about CLA? I requested access as compony contributor again. Maybe I need to reach out again internally.

@jstone-lucasfilm
Copy link
Copy Markdown
Member

@krohmerNV Alas, I don't have any direct influence over EasyCLA approvals, but the Linux Foundation usually responds quickly when you fill out a support ticket, as described in the comment from their automated system:

#2261 (comment)

krohmerNV and others added 2 commits March 10, 2025 13:37
@krohmerNV krohmerNV force-pushed the krohmer/MDL-fix-aggegate-struct-syntax branch from c9de50d to b218335 Compare March 10, 2025 12:37
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
@jstone-lucasfilm jstone-lucasfilm changed the title Override the aggregated struct printing for MDL code gen Override aggregated struct generation for MDL Mar 10, 2025
@jstone-lucasfilm jstone-lucasfilm merged commit 2992308 into AcademySoftwareFoundation:main Mar 10, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants