Fix division by singular matrices in test suite#2299
Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Mar 24, 2025
Merged
Conversation
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Mar 24, 2025
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Good catch, @tdavidovicNV, and this change looks good to me.
jstone-lucasfilm
merged commit e0a9a25
into
AcademySoftwareFoundation:main
35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matrix division unit test uses a singular matrix as a divisor.
This change instead does matrix divison that will result is matrix with 1.5, 1.5, 1.5, 1.0 on the diagonal.
This in isolation will make the GLSL test produce NaNs, because of the issue #2089 , so merging PR #2298 first is highly recommended.