Optimization to MslProgram::updateAttributeList#2317
Merged
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom Mar 27, 2025
Merged
Conversation
…am build() invocation - instead of repeatedly
jstone-lucasfilm
changed the title
MslProgram::updateAttributeList performance
jstone-lucasfilm
changed the title
MslProgram::updateAttributeList performanceMslProgram::updateAttributeList
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
approved these changes
Mar 27, 2025
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Thanks for the optimization, @ld-kerley!
jstone-lucasfilm
merged commit 20fd8f4
into
AcademySoftwareFoundation:main
35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #2309
introduce guard to avoid repeatedly setting the value and type string for the
_attributeList.