Skip to content

Fix zenity invocation for KDE#2517

Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
jreichel-nvidia:fix-zenity-invocation-for-kde
Nov 6, 2025
Merged

Fix zenity invocation for KDE#2517
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
jreichel-nvidia:fix-zenity-invocation-for-kde

Conversation

@jreichel-nvidia
Copy link
Copy Markdown
Contributor

The KDE file open dialog hangs because of the trailing space.

The KDE file open dialog hangs because of the trailing space.
@jreichel-nvidia
Copy link
Copy Markdown
Contributor Author

Can someone take care of NanoGUI which has the same problem (affects MaterialXView)?

@jstone-lucasfilm jstone-lucasfilm changed the title Fix zenity invocation for KDE. Fix zenity invocation for KDE Nov 6, 2025
Copy link
Copy Markdown
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @jreichel-nvidia!

@jstone-lucasfilm jstone-lucasfilm merged commit 92bfb86 into AcademySoftwareFoundation:main Nov 6, 2025
32 checks passed
@jreichel-nvidia
Copy link
Copy Markdown
Contributor Author

For reference: In newer versions of NanoGUI the problem has been fixed here:

commit 1cbff2e8d79507e77ab000ee5282c35694689ade
Author: Wenzel Jakob wenzel.jakob@epfl.ch
Date: Fri Aug 29 18:55:10 2025 +0200

Switch file open/save dialog provider to ``nativefiledialog-extended``

This commit replaces the hand-written file dialog code in common.cpp
with the library https://github.com/btzy/nativefiledialog-extended.

The main consequence of this change is that the Linux implementation of
these operations switches from zenity to xdg-desktop-portal, causing the
file dialogs to also work in containers (e.g., flatpak) and non-GTK
based distributions like KDE. The library also has explicit support for
Wayland.

@jstone-lucasfilm
Copy link
Copy Markdown
Member

Ah, that's good to know, @jreichel-nvidia. I'm glad Wenzel is still making improvements to NanoGUI, and we should update our submodule reference to the latest commit when time permits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants