Fix interpretation of subsurface weight in MDL#2536
Merged
jstone-lucasfilm merged 5 commits intoAcademySoftwareFoundation:mainfrom Sep 2, 2025
Merged
Conversation
pablode
added a commit
to pablode/gatling
that referenced
this pull request
Aug 28, 2025
Apparently this was not a codegen issue, but rather a bug in the SSS implementation: AcademySoftwareFoundation/MaterialX#2536
… instead enable/disable the effect in general. This means the semantic is meant for composition.
krohmerNV
force-pushed
the
krohmer/PR_MDL_fix_subsurface_weight_semantic
branch
from
b35575b to
0dd223e
Compare
Contributor
Author
|
Note, i added a few more materials to the tests because the pbrlib tests have been limited to surfaceshaders only. I'm not sure this was intentional. |
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, @krohmerNV!
The only change that I'd recommend we omit is the extension of the default renderTestPaths.
Although this is definitely the right direction for the future, I'd like to defer this until we add support for controlling the order in which tests are organized into the final PDF, rather than the simple alphabetical order currently used.
This changelist restores the original set of render test paths for now, as we'd like to improve our control over the organization in the PDF before adding new renders by default. Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Sep 2, 2025
jstone-lucasfilm
merged commit 5beba1a
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subsurface weight should not be applied to the expected color but instead enable/disable the effect in general.
This means the semantic of the weight is meant for composition rather than turning down the volume absorption and scattering itself.
With the performance optimizations for Standard Surface and OpenPBR this issue surfaced since weights are not 1.0 anymore.