Modernize value string logic for C++17#2538
Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Sep 16, 2025
jstone-lucasfilm:dev_cpp_17
Merged
Modernize value string logic for C++17#2538jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom jstone-lucasfilm:dev_cpp_17
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm:dev_cpp_17
Conversation
This changelist modernizes the value string logic in `toValueString` and `fromValueString`, replacing C++11 SFINAE templates with C++17 `if constexpr` statements, and removing the intermediate stringToData and dataToString functions.
ld-kerley
approved these changes
Sep 3, 2025
Contributor
ld-kerley
left a comment
ld-kerley
left a comment
There was a problem hiding this comment.
Looks good to me - I'm assuming you'll merge this after the 1.39.4 RC phase has closed?
Member
Author
|
@ld-kerley Thanks for the review! And yes, this seems like a good candidate for the early phases of 1.39.5, as we'll need wider testing than we can achieve within 1.39.4. |
niklasharrysson
approved these changes
Sep 5, 2025
Contributor
niklasharrysson
left a comment
niklasharrysson
left a comment
There was a problem hiding this comment.
Looks good to me too!
jstone-lucasfilm
merged commit ee339d2
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist modernizes the value string logic in
toValueStringandfromValueString, replacing C++11 SFINAE templates with C++17if constexprstatements, and removing the intermediate stringToData and dataToString functions.