Add derivation for OSL field of view#2572
Add derivation for OSL field of view#2572jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom jstone-lucasfilm:dev_field_of_view
Conversation
Historically, we've aligned our OSL render tests with GLSL and other languages using an empirically determined field of view, as we didn't yet understand why a default 45-degree field of view didn't produce the expected results in OSL `testrender`. We now have a better sense of the underlying issue, where OSL `testrender` uses screen-space coordinates in the [-0.5, 0.5] range, while GLSL and other languages use screen-space coordinates in the [-1, 1] range. This changelist adds a mathematical derivation for the OSL field of view, and replaces the original empirical value with an exact computed value.
jstone-lucasfilm
requested review from
fpsunflower,
kwokcb and
niklasharrysson
|
This is not really intentional. I looked over the code and its indeed using a slightly odd convention that would not align with most renderers. We should probably fix it - its just a quirk of the current implementation. |
|
@fpsunflower That's good to know, and we'd be happy to handle this setting differently in new builds of OSL, with the compensation factor only used in older builds. |
|
I'm curious if we can set camera |
|
Yes, but that change needs to be in the |
|
I believe @fpsunflower is correct that we'd need updates on the As of today, this change just provides a mathematical explanation for the magic number that we've been using in our @kwokcb @niklasharrysson Does this seem like a worthwhile improvement that we should integrate into our codebase for MaterialX 1.39.5? |
niklasharrysson
left a comment
niklasharrysson
left a comment
There was a problem hiding this comment.
Great to have this sorted and an exact FOV derived!
jstone-lucasfilm
merged commit 6eb2873
into
AcademySoftwareFoundation:main
4 participants
Historically, we've aligned our OSL render tests with GLSL and other languages using an empirically determined field of view, as we didn't yet understand why a default 45-degree field of view didn't produce the expected results in OSL
testrender.We now have a better sense of the underlying issue, where OSL
testrenderuses screen-space coordinates in the [-0.5, 0.5] range, while GLSL and other languages use screen-space coordinates in the [-1, 1] range.This changelist adds a mathematical derivation for the OSL field of view, and replaces the original empirical value with an exact computed value.