Support IOR in Standard Surface to glTF PBR translation#2589
Merged
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom Sep 28, 2025
Merged
Support IOR in Standard Surface to glTF PBR translation#2589jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Thanks for this improvement, @bowald! I had just a minor note about the inclusion of doc strings, but otherwise this looks great.
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
approved these changes
Sep 26, 2025
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @bowald!
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit 95073cb
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passthrough of Index of Refraction.
closes #2582
Note that glTF uses IoR for Fresnel when Specular extension is used. So if Specular is 1.0 in both gltf_pbr and standard_surface, the result will differ (more info in KHR_materials_specular ), see last figure. However, if not the specular extension in glTF is used, the ior matches.
Test material: Glass - AMD GPU Open (but with varying
Index of refractionandspecular)Index of Refraction 1.0 | Specular 0.0
Standard Surface
Translated to gltf_pbr
Index of Refraction 1.1 | Specular 0.0
Standard Surface
Translated to gltf_pbr
Index of Refraction 1.5 | Specular 0.0
Standard Surface
Translated to gltf_pbr
Index of Refraction 1.0 | Specular 1.0
Standard Surface
Translated to gltf_pbr