Support emissive strength in Standard Surface to glTF PBR#2593
Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Sep 30, 2025
Merged
Conversation
jstone-lucasfilm
approved these changes
Sep 26, 2025
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @bowald!
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit 3435676
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #2584
Instead of multiplying the emissive color (factor) and the emission (strength) in the translation graph, we now pass them through to the
gltf_shader, which do the multiplication, since KHR_materials_emissive_strength is implemented ingltf_pbr.The main difference in the current implementation between standard surface and gltf_pbr for emission is that standard surface takes the coat into consideration (as emission is below the coat layer). The gltf spec also layers emission below the coat, however not implemented in
gltf_pbrcurrently, more info in issue: #2592. Even if the coat interaction differs a bit, I think we can just pass the emission and emission color through as both the shading models otherwise have the same implementation.Standard surface implementation:
gltf_pbr implementation:
