Fix image search path for Metal render test suite#2667
Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Nov 13, 2025
Merged
Fix image search path for Metal render test suite#2667jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Passed in image search path was not being used by image handler so some images would not be found.
jstone-lucasfilm
approved these changes
Nov 12, 2025
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Good catch, thanks @kwokcb!
jstone-lucasfilm
merged commit 6029ef4
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #2664.
where some tests would not find images in relative paths.
Change
Pass image search path to image handler search path for MSL test renderer.
Results
Example results. There are no image missing warnings anymore.
Notes
being commented out.